GithubHelp home page GithubHelp logo

Comments (4)

pelikhan avatar pelikhan commented on July 21, 2024 1

Should be fixed now.

from pxt-midi.

Gadgetoid avatar Gadgetoid commented on July 21, 2024

I think there are a few bugs like this in the code, see: https://www.midi.org/specifications-old/item/table-1-summary-of-midi-message

https://github.com/Microsoft/pxt-midi/blob/93ac2070833d169fe259dffd119a79992ae6a4ff/midi.ts#L243-L245

0xf masks to a 4-bit number, but the specification details both the key and value as 7-bit.

https://github.com/Microsoft/pxt-midi/blob/93ac2070833d169fe259dffd119a79992ae6a4ff/midi.ts#L285-L287

Again, as you mention, should be 7-bit (0-127)

Same with channelMode

from pxt-midi.

linclip avatar linclip commented on July 21, 2024

Please also fix the version described in pxt.json of "pxt-bluetooth-midi".

"midi": "github:Microsoft/pxt-midi#v2.0.3"
to
"midi": "github:Microsoft/pxt-midi#v2.1.3"

from pxt-midi.

linclip avatar linclip commented on July 21, 2024

I confirmed that pxt-bluetooth-midi has been fixed. Thank you.

from pxt-midi.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.