Cannot open SARIF files containing URIs that are empty strings about sarif-visualstudio-extension

[simmse]

I have just tested with a web beta sarif validator. The outcome is exactly the same as this extension. I do not know from this result, whether the root cause is within the extension, Visual Studio, or the JSON based schema.

@simmse Can you share a SARIF file that gives you this error? It would be ideal if you had a sanitized (not containing any sensitive or confidential information) and minimal SARIF file that demonstrates the problem.

It would also help if I knew the exact compiler command line that produced the file.

Thanks!

P.S. The error message is from a runtime exception in the code. It's not referring to the name of a SARIF property; it's just a parameter name, from code like this:

public void DoSomethingToFile(string path)
{
    if (path == null) throw new ArgumentNullException(nameof(path));
    ...
}

It has nothing to do with the SARIF standard.

[simmse]

@lgolding Perhaps something has been modified in the more recent 2019 Visual Studio (e.g. 16.1.4). When I open with File | Open, the editor area displays the file. I am not sure what is supposed to happen now. I can see the sarif (attached). Beyond that it is not clear what else is supposed to occur. The preview 2019 version I have is 16.1.0 Preview 2.0. Please remove the .txt ending to observe .sarif behavior. Remember that this originates from the demo sample by Microsoft.
annotations.nativecodeanalysis.sarif.txt

Ok, thank you for the repro file. I can reproduce your observation:

1. I am running VS 2019 v16.1.4.

2. I have installed the Microsoft SARIF Viewer extension, v2.1.3 (the latest).

3. I removed the ".txt" extension from the file annotations.nativecodeanalysis.sarif.txt.

4. In VS, I do File, Open and select annotations.nativecodeanalysis.sarif.

5. The viewer notices that the sample file does not conform to the final, official version of SARIF (which is 2.1.0), and so it automatically translates the file to the latest version, and offers to save the transformed file. I said "No", but you can say "Yes" if you like:

6. ... and it crashes:

I will debug this and provide a fix. Thanks!

@simmse Ok, I know what the trouble is. In the course of converting from the old to the new version, we aren't handling the empty helpUri values in the input file. (Strictly speaking, that makes the input file invalid, but no matter.)

@michaelcfanning FYI. Diagnosing this I found a couple of unrelated bugs in the PrereleaseCompatibilityTransformer (@simmse, that's the component in the SARIF SDK that translates old version to the most current.) I will fix all of this, publish a new SDK NuGet, then update the viewer to use the latest NuGet.

I'll take care of this tomorrow.

Well, the root cause wasn't what I thought it was. Still looking. The good news is, I got some nice unit tests out of it ;-)

No, that is the root cause! My test had a bug. Now the test correctly shows the problem. I'll stop the stream of consciousness now...

@simmse, This is fixed. I'll publish a new VSIX to the marketplace as soon as our build pipeline finishes producing a signed binary.

@simmse, version 2.1.4 of the SARIF Viewer extension for Visual Studio is now available on the marketplace. Please let me know if this solves your problem.