GithubHelp home page GithubHelp logo

Comments (5)

smikula avatar smikula commented on May 21, 2024

I agree, this would be a good idea. It wouldn't be that hard to use the Satchel action type as the MobX action name. This doesn't 100% solve the problem because many mutators might respond to the same action, but in practice it's probably good enough.

We could add the optional parameter to mutators, but I'm wary of adding another field that's purely for diagnostic purposes. (Satchel's action.type is already superfluous except for diagnostics.)

from satcheljs.

dev-tim avatar dev-tim commented on May 21, 2024

Reusing action.type should be 100% sufficient. I'll prepare a PR that uses named actions.

from satcheljs.

dev-tim avatar dev-tim commented on May 21, 2024

Added PR with kind of naive approach - but should do the thing, happy to get some feedback.

from satcheljs.

smikula avatar smikula commented on May 21, 2024

@dev-tim, I just merged your change. I'll get a new release out soon, probably Monday. Thanks for the fix!

from satcheljs.

smikula avatar smikula commented on May 21, 2024

@dev-tim, I just published v4.1.0. Let me know if you run into any more problems.

from satcheljs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.