Comments (5)
I agree, this would be a good idea. It wouldn't be that hard to use the Satchel action type as the MobX action name. This doesn't 100% solve the problem because many mutators might respond to the same action, but in practice it's probably good enough.
We could add the optional parameter to mutators, but I'm wary of adding another field that's purely for diagnostic purposes. (Satchel's action.type
is already superfluous except for diagnostics.)
from satcheljs.
Reusing action.type
should be 100% sufficient. I'll prepare a PR that uses named actions.
from satcheljs.
Added PR with kind of naive approach - but should do the thing, happy to get some feedback.
from satcheljs.
@dev-tim, I just merged your change. I'll get a new release out soon, probably Monday. Thanks for the fix!
from satcheljs.
@dev-tim, I just published v4.1.0. Let me know if you run into any more problems.
from satcheljs.
Related Issues (20)
- Best Practices for Resolvers HOT 6
- React Hooks HOT 3
- Docs: Consider moving Docs into /docs directory instead of gh-pages branch
- when is the next release planned to move Satchel JS 4.x version out of beta? HOT 2
- Proposal: Move orchestration to a middleware HOT 2
- Prohibit calling legacy satchel actions from mutators
- Prohibit mutatorActions from returning values or being async HOT 1
- Any plan to bump mobx and mobx-react to the latest version? HOT 6
- Is there guide about how to write test? HOT 1
- This repo is missing important files
- It's too easy use select() incorrectly HOT 2
- select should give a better error if you select something that isn't observable HOT 1
- Is the documentation up to date? HOT 2
- mobx / mobx-react should be peerDependencies? HOT 4
- Switch to new version of mobx HOT 5
- Question: How can i wait promise from action()? HOT 2
- Deprecate orchestratorAction HOT 3
- Guard against multiple stores with the same name
- Proposal for improved mutator API HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from satcheljs.