Sidebar and settings are shown at the same time about terminal

[AlejandroBlanco2001]

Hey @marcelwgn @zadjii-msft , I was able to reproduce it on my W10 machine with the version of the terminal 1.19.10573.0. I followed the same steps as mentioned in the description.

If possible, I would like to investigate this issue a little bit more

[AlejandroBlanco2001]

@zadjii-msft @marcelwgn PR opened 😄

[zadjii-msft]

Huh, we saw this before in #9337 which should have been fixed in #9752, back in 1.8.

Though, it seems like those resources got lost some time ago: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsEditor/MainPage.xaml

Oh dear it was lost in #12973

[marcelwgn]

That's odd, I'm unable to reproduce this issue. Might this be a Win 10 issue maybe?

[AlejandroBlanco2001]

@marcelwgn, apologies for the delayed update. The concept suggested by @zadjii-msft in #9752 is the root cause of the issue addressed by the changes implemented in #9752. These changes enable the modification of the panel's color when it's not being rendered (using AcrylicBrush with the property FallbackColor). However, in change #12973, we altered this to utilize a solid transparent background instead. My inquiry is whether we should strive to replicate the same functionality with the subsequent implementation, or revert to the solution put forth in #9752. For simplicty, I would stick with the previous way, I'm happy to make the changes in a PR once the question is answered 😄

[zadjii-msft]

I'd honestly just revert back to the acrylic brush with a fallback color set. This is so wacky when it does happen, that literally anything would be better than this 😅

[AlejandroBlanco2001]

@zadjii-msft Sure, I will do that today, and I will submit the PR. Thanks for the feedback 😄