Comments (6)
Hi I'm an AI powered bot that finds similar issues based off the issue title.
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!
Closed similar issues:
- wordDelimiters not working inside tmux with [shift]+[left mouse click] (#9382), similarity score: 0.81
Note: You can give me feedback by thumbs upping or thumbs downing this comment.
from terminal.
Thanks for filing! We're having trouble reproducing this. Would you be able to write up the steps required to get in this state /? This'll help us take a closer look 😊
from terminal.
@carlos-zamora Below is another screen shot where we can reproduce it -
Open a terminal - adjust the width to say 80 or less. Width shouldn't matter here but it makes easy to repro
Start a tmux session with two vertical split panes
Type some lengthy strings in both panes.
Now shift-doubleclick on a string on one pane - terminal will expand the selectoin to other pane.
My word delimiters are set to "()"',;<>!@#$%^&*|+[]{}?│"
from terminal.
Does this repro on Windows Terminal Canary?
from terminal.
Yes, just download (ver:1.22.1631.0) it and i can see the issue there also
from terminal.
We think this should be fixed by a combination of #15602 and some of the recent ConPTY work we've been doing. We're going to move the info over from that issue over here though since this has a nice test for it.
From what I understand, a row should only be marked as force-wrapped if we actually wrote past the last column, which naturally occurs already in the AdaptDispatch::_DoLineFeed
call.
Removing the SetWrapForced
call however breaks these unit tests:
ConptyOutputTests::InvalidateUntilOneBeforeEnd
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet0
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet1
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet2
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet3
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet4
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet5
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::ResizeRepaintVimExeBuffer
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet7
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet8
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet7
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet8
They break because when a ROW
is not marked as force-wrapped the output behavior of the VtEngine and its output changes. We need to investigate why they break, what the correct behavior should be and how we can fix it. Presumably most unit tests simply assert the wrong behavior, but it's also possible that VtEngine::_PaintUtf8BufferLine
and its removeSpaces
variable may have to be updated.
from terminal.
Related Issues (20)
- Command line "-F" (fullscreen) in an already running instance? HOT 4
- changing the app name independently of the language settings HOT 1
- Clipboard gets overridden when pasting to a tab with a previous selection with right click or Shift+Insert, when copy-on-select is enabled HOT 2
- Large drop in performance when using font features HOT 3
- After entering the font, a black color block will appear when rolling back HOT 2
- Bell not silent despite bellStyle being set to "none" HOT 2
- Add support for the S8C1T/S7C1T escape sequences HOT 2
- Cannot install/update Windows Terminal: error 0x80070005 HOT 1
- Docs HOT 1
- [Terminal Chat] Copying a suggestion with multiple lines is pasted improperly
- [Terminal Chat] Shift+Enter should add a newline in the textbox
- [Terminal Chat] No way to copy text from chat history
- Feature request: option to remove profile icon completely
- Sixel band with solid background color get transparent in some cases HOT 7
- Resizing the font while playing a sixel video can trigger a crash
- Emojis still crashing conhost.exe HOT 2
- Preview `1.22.2362.0` breaks Terminal.Gui apps HOT 6
- uho HOT 1
- Microsoft store version is too old, documentation is incorrect HOT 1
- Win+Number on Taskbar pinned Windows Terminal create multiple tmux client. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminal.