GithubHelp home page GithubHelp logo

Comments (8)

github-actions avatar github-actions commented on September 25, 2024 1

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

from terminal.

lhecker avatar lhecker commented on September 25, 2024

Huh, weird. I thought those triangle glyphs were narrow (1 cell wide)? I just installed the latest version of Ubuntu Mono NF (version 0.80) and U+E0B8, U+E0BA, U+E0BC, and U+E0BE are all narrow for me.

What Ubuntu Mono font are you using? NF (UbuntuMonoNerdFont-Regular.ttf), NFM (UbuntuMonoNerdFontMono-Regular.ttf), or NFP (UbuntuMonoNerdFontPropo-Regular.ttf)?

Can you figure out what codepoints your status line uses, or otherwise give me a printf command (or similar) that allows me to reproduce the issue locally?

from terminal.

SivanagBalla avatar SivanagBalla commented on September 25, 2024

I'm using an earlier verion of Ubuntu Mono NF which i downloaded from https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/UbuntuMono/Regular/UbuntuMonoNerdFont-Regular.ttf
This version has those characters(U+E0B8, U+E0BA, U+E0BC, and U+E0BE) to be double wide.

Sometime down the line (around year back i believe), they (ryanoasis/nerd-fonts) updated those characters to be narrow. So the latest version still have them as narrow.

I kept the older version of font file. Here it is. If you want to try this, you may want to remove the already installed one.
UbuntuMono Nerd Font.zip

from terminal.

zadjii-msft avatar zadjii-msft commented on September 25, 2024

There's a couple ways I could see us taking this:

  • This is by-design, the PL glyphs are supposed to be single-wide now, and the terminal is correctly rendering them as such. Users can always opt-out of the Terminal doing this with "font.builtinGlyphs": false...
  • ... though, with "font.builtinGlyphs": false, we still should probably render these a little better
  • alternatively, I'm not sure if we can check the font ahead of time, and manually scale our PL drawing to the same width the font expects them to be

from terminal.

lhecker avatar lhecker commented on September 25, 2024

Users can always opt-out of the Terminal doing this with "font.builtinGlyphs": false...

FYI you can also find the setting here:
image

I think we should consider closing this as "by design" for the following reasons:

  • Newer version of NF have these glyphs as narrow.
  • Adjusting the width of builtin glyphs to match the font would break their biggest strength of being fully "gap-less".
  • Adjusting the size of font glyphs in the past has repeatedly proven itself to be very error prone. Adjusting the vertical/horizontal alignment is less bad, but still somewhat error prone. It should be reserved to situations where there aren't any alternatives.

@SivanagBalla Is there a reason why you don't want to use a newer Ubuntu Mono NF version?

from terminal.

SivanagBalla avatar SivanagBalla commented on September 25, 2024

I liked the older double wide verison of these characters and so i kept it.
Anyway, turning off Builtin Glyphs worked. This is good enough for me. But does this option have any other side effects?

from terminal.

lhecker avatar lhecker commented on September 25, 2024

No, it simply disables these builtin glyphs:
image

The benefit of them being builtin is that they're "pixel perfect", unlike the corresponding glyphs in a font.

from terminal.

zadjii-msft avatar zadjii-msft commented on September 25, 2024

Yea I second closing by design. If disabling the builtin glyphs works for you, that's probably the best we'll be able to do in the general case.

Thanks for following up! TIL that there was a version of NF where those glyphs were double-wide

from terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.