GithubHelp home page GithubHelp logo

Comments (6)

adamjstewart avatar adamjstewart commented on August 15, 2024

For testing, I think we can add a matrix field like:

matrix:
    dep-version: [oldest, latest]

Then, during action setup, if: ${{ matrix.dep-version == 'oldest' }}, we can run sed on requirements.txt to replace >= with ==.

We could also use an include: so that we don't have to run every test twice. Still haven't decided if we need to test this just for pytest or for all actions. Also not sure how to detect the minimum version without trying everything and seeing what breaks.

from torchgeo.

adamjstewart avatar adamjstewart commented on August 15, 2024

pypa/pip#8085 would greatly help with this if it ever gets implemented.

from torchgeo.

calebrob6 avatar calebrob6 commented on August 15, 2024

We depend on the latest release candidate of pytorch-lightning (1.4.0) to fix an issue with mypy (the problem where mypy doesn't think a LightningModule's hparams property is indexable)

from torchgeo.

adamjstewart avatar adamjstewart commented on August 15, 2024

I would like to differentiate between dependency versions required for torchgeo to function and versions required for things like mypy to pass. We have hundreds of comments across torchgeo that ignore mypy warnings due to missing typing. These will likely change frequently. So the actual version required by torchgeo should be the minimum where the pytest tests pass. For things like mypy/Sphinx, we will always use the latest release.

from torchgeo.

adamjstewart avatar adamjstewart commented on August 15, 2024

Now that we're using requirements.txt and dependabot, I think it wouldn't be unreasonable to add a CI test that uses a separate requirements-min.txt with the minimum known working versions of our deps. We can then make sure the full range works as expected.

from torchgeo.

adamjstewart avatar adamjstewart commented on August 15, 2024

Just discovered that matplotlib does the same thing: https://github.com/matplotlib/matplotlib/blob/main/requirements/testing/minver.txt

from torchgeo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.