GithubHelp home page GithubHelp logo

Comments (7)

bryanmacfarlane avatar bryanmacfarlane commented on June 18, 2024 1

Thanks for the feedback. I'll consider this.

from typed-rest-client.

kaeedo avatar kaeedo commented on June 18, 2024

In my use case, I also need to do this. Would be nice to have as a config option. I'm willing to submit a PR if you want

from typed-rest-client.

bryanmacfarlane avatar bryanmacfarlane commented on June 18, 2024

@keedo, PRs are welcome.

from typed-rest-client.

bryanmacfarlane avatar bryanmacfarlane commented on June 18, 2024

Note that we're not stripping - the base url is the host portion of the url and then we add the relative paths. What it should do is if the "base url" has a path portion, it should save that off and then on every request pre-pend to the path given. Will need a bunch of tests for combinations ...

PRs welcome or I will get to soon.

from typed-rest-client.

kaeedo avatar kaeedo commented on June 18, 2024

Created PR for this: #23

from typed-rest-client.

bryanmacfarlane avatar bryanmacfarlane commented on June 18, 2024

done

from typed-rest-client.

MadhuvanthG avatar MadhuvanthG commented on June 18, 2024

I'm using 1.8.1 and don't see that this issue has been fixed. Do we need to pass an additional param to preserve the path in baseURL? Looking at the code in the mentioned PR, looks like a flag was added and later removed to make this behavior (preserving path) the default one.

from typed-rest-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.