Comments (10)
How do you know those files are unused? eg. BusinessDetails
doesn't appear in bingmaps/index.d.ts
nor is the Microsoft.Maps.Directions.d.ts
file referenced there.
from types-publisher.
I believe @andy-ms means published by the types-published by "used ". so we should warn the package author that these files will never make it to the corresponding @types
package. they have two options, either put them in the tsconfig.json
, or add a /// <reference path.. ./>
to them.
from types-publisher.
@andy-ms how would you handle cases like older versions of the library?
from types-publisher.
We would have to add functionality to handle multiple versions first.
from types-publisher.
What about typings for https://github.com/normalize/mz? There is no main entry point, but an fs.js
, child_process.js
etc. that are importet with import * as fs from 'mz/fs'
.
from types-publisher.
The files are listed in the tsconfig.json, so they get published.
from types-publisher.
Fixed by #264.
from types-publisher.
Hi, DT types-2.0 branch seems to be failing due to this check:
First I get this error:
# Typing Publish Report Summary
Started at Tue, 17 Jan 2017 15:10:11 GMT
Found 2719 typings folders in C:\Work\repos\DefinitelyTyped
Error: In C:\Work\repos\DefinitelyTyped/ace: Expected file 'all-tests.ts' to be named ace-tests.ts
at C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\src\lib\definition-parser.ts:155:12
at next (native)
at fulfilled (C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\bin\lib\definition-parser.js:4:58)
After that is fixed, I get this other error even after referencing the file in ace-tests
:
# Typing Publish Report Summary
Started at Tue, 17 Jan 2017 15:13:33 GMT
Found 2719 typings folders in C:\Work\repos\DefinitelyTyped
Error: Directory C:\Work\repos\DefinitelyTyped/ace/tests has unused file ace-anchor-tests.ts
at C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\src\lib\definition-parser.ts:311:11
at next (native)
at fulfilled (C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\bin\lib\definition-parser.js:4:58)
To reproduce a clean npm install
is needed so the last types-publisher
version is installed.
from types-publisher.
See DefinitelyTyped/DefinitelyTyped#13233
from types-publisher.
Great. I just saw the comment on my PR to types-2.0.
from types-publisher.
Related Issues (20)
- Please add vue-property-decorator to the whitelist HOT 7
- Please make `checkTypeScriptVersions` aggregate version mismatches
- Scoped & versioned packages can't pass path mappings checks
- Resurrect crawl-npm.ts
- Improve notNeededPackages.json testing HOT 1
- Update outdated packages HOT 1
- testDependencies should include only top-level package names HOT 1
- publish-registry validation fails when new packages are out but we won't publish them for a week
- Changes published from DefinitelyTyped are not marked as 'latest' HOT 1
- 'download' is not allowed in new npm package names
- Can't unpublish fastify-static HOT 2
- Deprecated packages often fail to publish correctly
- types-publisher is crashing during indexing HOT 3
- Optional catch binding in util.ts is failing PRs on DefinitelyTyped
- Error running tests (Error: Unexpected path .DS_Store) HOT 1
- index.d.ts should be the only d.ts file allowed in tsconfig.json HOT 10
- Tests do not run reliably on Windows
- getLatestMatch throws "Could not find version [object Object]"
- Dependencies information in NPM registry saved with "^[object Object]" value HOT 1
- typesVersions gets mangled in the published package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from types-publisher.