GithubHelp home page GithubHelp logo

Comments (10)

alexeagle avatar alexeagle commented on August 19, 2024

How do you know those files are unused? eg. BusinessDetails doesn't appear in bingmaps/index.d.ts nor is the Microsoft.Maps.Directions.d.ts file referenced there.

from types-publisher.

mhegazy avatar mhegazy commented on August 19, 2024

I believe @andy-ms means published by the types-published by "used ". so we should warn the package author that these files will never make it to the corresponding @types package. they have two options, either put them in the tsconfig.json, or add a /// <reference path.. ./> to them.

from types-publisher.

mhegazy avatar mhegazy commented on August 19, 2024

@andy-ms how would you handle cases like older versions of the library?

from types-publisher.

 avatar commented on August 19, 2024

We would have to add functionality to handle multiple versions first.

from types-publisher.

felixfbecker avatar felixfbecker commented on August 19, 2024

What about typings for https://github.com/normalize/mz? There is no main entry point, but an fs.js, child_process.js etc. that are importet with import * as fs from 'mz/fs'.

from types-publisher.

 avatar commented on August 19, 2024

The files are listed in the tsconfig.json, so they get published.

from types-publisher.

 avatar commented on August 19, 2024

Fixed by #264.

from types-publisher.

pmoleri avatar pmoleri commented on August 19, 2024

Hi, DT types-2.0 branch seems to be failing due to this check:

First I get this error:

# Typing Publish Report Summary
Started at Tue, 17 Jan 2017 15:10:11 GMT
Found 2719 typings folders in C:\Work\repos\DefinitelyTyped
Error: In C:\Work\repos\DefinitelyTyped/ace: Expected file 'all-tests.ts' to be named ace-tests.ts
    at C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\src\lib\definition-parser.ts:155:12
    at next (native)
    at fulfilled (C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\bin\lib\definition-parser.js:4:58)

After that is fixed, I get this other error even after referencing the file in ace-tests:

# Typing Publish Report Summary
Started at Tue, 17 Jan 2017 15:13:33 GMT
Found 2719 typings folders in C:\Work\repos\DefinitelyTyped
Error: Directory C:\Work\repos\DefinitelyTyped/ace/tests has unused file ace-anchor-tests.ts
    at C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\src\lib\definition-parser.ts:311:11
    at next (native)
    at fulfilled (C:\Work\repos\DefinitelyTyped\node_modules\types-publisher\bin\lib\definition-parser.js:4:58)

To reproduce a clean npm install is needed so the last types-publisher version is installed.

from types-publisher.

 avatar commented on August 19, 2024

See DefinitelyTyped/DefinitelyTyped#13233

from types-publisher.

pmoleri avatar pmoleri commented on August 19, 2024

Great. I just saw the comment on my PR to types-2.0.

from types-publisher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.