Comments (8)
Changing to spec issue. The new compiler supports merging of all module declarations, including ambient external module declarations. I see no reason why we should only allow merging of internal modules and specifically disallow merging of ambient external modules. In particular, declaration files sometimes extend existing internal modules and may want to do exactly that for ambient external modules.
from typescript.
From design meeting: agreed this should merge just like internal modules.
from typescript.
Leaving open so we can make the text change to the spec
from typescript.
When I run this code in typescript I get
ldixon/foo.ts(4,16): error TS2000: Duplicate identifier '"fs"'. Additional locations:
ldixon/foo.ts(1,16)
ldixon/foo.ts(4,16): error TS2191: Ambient external module declaration cannot be reopened.
Sounds like the correct behaviour is no errors. Would be great to have an npm publish of a version with this fixed :)
from typescript.
agreed this should merge just like internal modules.
DT actually needs this. Thanks guys (/cc @Bartvds @vvakame will possibly make non-instantiated modules less necessary)
from typescript.
It seems like this doesn't work if the module is exported by assignment?
declare module "m" {
function inner(s: string);
module inner { export interface Test {t: string;} }
export = inner //error here
}
declare module "m" {
// even though we're only extending already existing submodule
module inner { export interface Other { t: number; } }
}
from typescript.
@spion The name inner
is not "shared" between declarations here -- when there's an export =
, all other declarations inside that module declaration are considered to not be visible at all
from typescript.
@RyanCavanaugh I see. The original problem is express.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/express/express.d.ts
Here, express exposes a namespace Express
to let us extend Request
. Unfortunately those extensions cannot contain types imported from ambient external modules, which means they're of limited use. However, since express-the-module is also a function, the only way to declare the module is to use declaration merging then write export = module at the end, so we can't use declaration merging for ambient external modules either.
I'll open a separate issue.
from typescript.
Related Issues (20)
- Default type parameter values always shown on hover HOT 2
- Taking TypeScript for a spin for first time, errors for resizable ArrayBuffer HOT 7
- Shallow copy of Map class produce incorrect typings HOT 1
- Passing spreading array to function parameters should raise an error HOT 2
- `import defer` Stage 2.7 proposal support
- Types with optional props get implicit index signatures that cannot be made explicit HOT 1
- Presence of `export` affects narrowing HOT 3
- Mixin types are intersections rather than proper subclasses
- Duplicate keys do not error HOT 7
- JsDoc is missing/duplicated in declarations for overloads declared in classes declared in functions
- Allow excess properties in assignment if they were used in a `satisfies` check HOT 3
- Interface merging behaves inconsistently with respect to exports HOT 4
- `'X' only refers to a type` error in JSDoc comments HOT 1
- Hovering @param comments duplicates the comment in the hover HOT 3
- Design Meeting Notes, 7/23/2024
- verbatimModuleSyntax does not respect "exclude" option in tsconfig HOT 2
- Nonsensical error when creating a mixin with a type parameter HOT 1
- Web TS Server tries watching for files outside of project root HOT 1
- No completions for type parameters in generic function return type HOT 1
- Code generated by Webpack shows error in `exports` parameters in module lambdas as if they were a conflicting global `exports` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.