Comments (8)
Likely this is working as intended. There is a subtype relationship between Box<unknown>
is a strict subtype of Box<any>
and thus it's preferred when narrowing here. If the predicate's type would be preferred here then you would end up with Box<any>
here and that's not desirable:
interface Box<T> {
value: T;
}
function isBox(box: unknown): box is Box<any> {
return true;
}
declare class Dog {
bark(): void;
}
declare const smth: Box<number> | Dog;
if (isBox(smth)) {
smth.value;
// ^? Box<number>
}
from typescript.
If the predicate's type would be preferred here then you would end up with Box here and that's not desirable:
If the type guard is typed as box is Box<any>
then the any
is clearly desired.
It's fine if TypeScript tries to guess missing intent. But here we authored it as "narrow this to any
" so TypeScript shouldn't override it.
from typescript.
Narrowing is more like a filtering operation and not like a cast/assignment. Otherwise, you likely wouldn't be able to express "check if it's a Box and if it's a Box keep the type intact". We can check how this doesn't infer the type argument:
interface Box<T> {
value: T;
}
function isBox<T>(box: unknown): box is Box<T> {
return true;
}
declare class Dog {
bark(): void;
}
declare const smth: Box<number> | Dog;
if (isBox(smth)) {
// ^? function isBox<unknown>(box: unknown): box is Box<unknown>
smth.value;
// ^? Box<number>
}
from typescript.
If the type guard is typed as box is
Box<any>
then the any is clearly desired.
It really isn't. People in general hate any
appearing in their code unless it's via some extremely direct incantation.
This has been the behavior since at least 3.3 and I don't think this is a) surprising, since we haven't gotten other reports on it or b) a welcome change to all the people who wrote declarations of the form is F<any>
when they maybe should have written is F<unknown>
but will now see an infectious any
they didn't want.
from typescript.
I missed the regression part since I think I was working off the other example. I'll bisect to ensure we're on the same page here.
from typescript.
Yeah, the 4.9.5 behavior is just inconsistent for no obvious reason:
interface Box<T> {
value: T
}
function isBox(box: unknown): box is Box<any> {
return true
}
declare const box1: string | Box<unknown>;
if (isBox(box1)) {
box1.value
// ^?
// any
}
declare const box2: string | Box<{} | null | undefined>;
if (isBox(box2)) {
box2.value
// ^?
// {} | null | undefined
}
declare const box3: string | Box<string>;
if (isBox(box3)) {
box3.value
// ^?
// string
}
It doesn't make sense to narrow from unknown
to any
but not any of the other types.
from typescript.
note that IIRC Array.isArray(x)
is typed as x is Array<any>
- and obviously you don't want your values typed as e.g. number[] | number
to be "narrowed" to any[]
from typescript.
This issue has been marked as "Not a Defect" and has seen no recent activity. It has been automatically closed for house-keeping purposes.
from typescript.
Related Issues (20)
- TypeScript emits incorrect type for setters in JSDoc
- Function returning `never` in branch doesn't narrow type if it's not explicitly annotated HOT 3
- Type Intersection incorrect for optional parameters in functions with `exactOptionalPropertyTypes: true`. `undefined` type is flip based off Intersection types
- Inconsistent tsc behavior on TS 5.4 HOT 3
- VSCode TypeScript extension writes tracing to the wrong directory on Mac OS HOT 1
- computed property name in an interface error when using `[]` already HOT 3
- Proposal: Type-side `instanceof` keyword and functionality HOT 8
- tsserver.js CPU/Memory Spike HOT 3
- [NewErrors] 5.5.0-dev.20240414 vs 5.4.5 HOT 30
- [ServerErrors][TypeScript] 5.5.0-dev.20240414 HOT 12
- [ServerErrors][JavaScript] 5.5.0-dev.20240414 HOT 12
- TypeScript Fails to Infer Specific Generic Types as Expected HOT 2
- [BUG]: TypeScript throws errors when adding [key: string]: string if other properties are not of type string HOT 2
- Support importing types from a `.mts` file from within a CommonJS file. HOT 7
- `(nullable?.methodOrProperty ?? defaultValue) === defaultValue` should be a type guard HOT 11
- Type refinement on properties no longer refines the whole structure HOT 3
- Import intellisense not working HOT 14
- [TypeScript] 5.4.5 - if(true) {return -1} throws off control-flow analysis HOT 1
- WebGL(2) context methods don't allow null for resource parameters HOT 2
- Interface cannot override predicate return type with boolean HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.