GithubHelp home page GithubHelp logo

Comments (6)

fatcerberus avatar fatcerberus commented on July 25, 2024 3

Deferred helper type

Shouldn’t it be the other way around - a NonDeferred helper type? If you treat “non-deferred” as the default then you end up causing the same breaks you were trying to avoid (code that assumes a callback is deferred and has its narrowings cancelled prematurely)

plus I’d think that functions calling a callback immediately are probably in the minority relative to ones where it’s deferred/called asynchronously.

from typescript.

DanielRosenwasser avatar DanielRosenwasser commented on July 25, 2024 2

The idea is that this would be behind a --strict flag which takes a more conservative view of narrowing - and declaration sites would be able to opt out of that.

from typescript.

Josh-Cena avatar Josh-Cena commented on July 25, 2024 2

plus I’d think that functions calling a callback immediately are probably in the minority relative to ones where it’s deferred/called asynchronously.

I would postulate that most callbacks are array method callbacks, FWIW.

from typescript.

fatcerberus avatar fatcerberus commented on July 25, 2024 1

plus I’d think that functions calling a callback immediately are probably in the minority relative to ones where it’s deferred/called asynchronously.

…unless someone just got finished reading a monad tutorial and went mad with power after it finally clicked for them 🚎

from typescript.

fatcerberus avatar fatcerberus commented on July 25, 2024 1

Hmm… it seems like it’s probably pretty idiomatic today to do stuff like

let foo: Foo | null = createFoo();
foo.onFinished(() => {
    foo = null;
});
// now foo is fully initialized, pass it around

As a matter of principle I’d feel uncomfortable passing foo around before all its callbacks were registered, and it wouldn’t be feasible for me to turn this proposed flag on until the library writer updated their types to align, which might make it too breaky even for strict

My point stands about the potential for code bloat with Deferred vs. NonDeferred too

from typescript.

DanielRosenwasser avatar DanielRosenwasser commented on July 25, 2024

and it wouldn’t be feasible for me to turn this proposed flag on until the library writer updated their types to align, which might make it too breaky even for strict

This is a bit of my concern too - that people would try this out, find it's too painful, and forget to try to turn it on again in the future.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.