GithubHelp home page GithubHelp logo

Comments (8)

shaipetel avatar shaipetel commented on July 21, 2024 6

I know I am commenting on an older post, but IMHO "by design" is not a satisfactory answer...

I just spent some time trying to "fix" a non issue, since the API should return null/empty response but returns this obscure error instead.

Please take back to the product team to reconsider and return a valid response with an empty value.

from aspnet-snippets-sample.

jamescro avatar jamescro commented on July 21, 2024 5

Thanks for reporting this. The behavior you're seeing is by design, as per the product team.

from aspnet-snippets-sample.

jamescro avatar jamescro commented on July 21, 2024 1

@mjohl I no longer work for Microsoft, so I'm no longer involved with maintaining this sample. The sample in this repo is intended only to demonstrate how the service works. This repo isn't the best place to get the product team's attention. You might get more traction on StackOverflow.
(I don't disagree with you, by the way.)

from aspnet-snippets-sample.

mjohl avatar mjohl commented on July 21, 2024

I fully agree with @shaipetel on this one. Return null at least instead of an exception. The latency and load on apps are bad enough without the need to add error handling for something that should be null. Seriously....."by design" is such a cop out answer!

from aspnet-snippets-sample.

mjohl avatar mjohl commented on July 21, 2024

What is even more annoying is that the initial user returned will have manager as null, even if they have a manager, as expand does nothing.
So to fetch manager I have to run a separate query on every single user.
If you have to work with 300'000 plus profiles the performance to query for the manager on every single user you might as well not do it because it takes hours.

The expand should at least return the managers UPN on the property, but instead we are forced to over query the graph client.

@jamescro I take it this issue is not going to get opened again? The fact that it took 4 months to respond to the original issue is rather shocking as well.

from aspnet-snippets-sample.

mjohl avatar mjohl commented on July 21, 2024

@jamescro Thank you for the info. I will put it on StackOverflow and maybe / hopefully get some traction there.

from aspnet-snippets-sample.

thebaud2u avatar thebaud2u commented on July 21, 2024

@mjohl I know it's been a long time since then but did you get any answer for this ?

from aspnet-snippets-sample.

jasonjoh avatar jasonjoh commented on July 21, 2024

@thebaud2u see my response in the linked issue #46.

from aspnet-snippets-sample.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.