GithubHelp home page GithubHelp logo

Comments (13)

uryelah avatar uryelah commented on August 16, 2024 1

I'm closing this issue since it's already being handled at the pathwright and code review instructions repo.

from linters-config.

SpaYco avatar SpaYco commented on August 16, 2024

the chmod 775 bin/main wouldn't help, it does work, but since this file will be used across all project, it might create a problem

i tested that chmod when the file doesn't exist, and it gives an error

image

we should either remove the cop, or add a comment and tell students to uncomment it on this project

from linters-config.

uryelah avatar uryelah commented on August 16, 2024

We might need to make using WSL obligatory for Windows users if there's no other way.

from linters-config.

SpaYco avatar SpaYco commented on August 16, 2024

after some digging, found a simple solution which is to update the file through git

using git update-index --chmod=+x .\lib\main then git add, commit and push would solve the problem

from linters-config.

shshamim63 avatar shshamim63 commented on August 16, 2024

Hi @uryelah and @SpaYco
Can I get the PR so that I can also apply some changes, please?

from linters-config.

SpaYco avatar SpaYco commented on August 16, 2024

@shshamim63 we haven't made a PR for this, but I've made an MR in the guidelines here

from linters-config.

shshamim63 avatar shshamim63 commented on August 16, 2024

I think renaming the file main.rb will resolve the issue. If you check the instruction in the pathwright it mentions main.rb and for bash command, it asks for bin/main.rb. Can you please confirm renaming the file resolves the issue or not?
image

from linters-config.

uryelah avatar uryelah commented on August 16, 2024

@shshamim63 Changing the file name, including the .rb extension at its end, does not help in this case, the error still shows up.

from linters-config.

shshamim63 avatar shshamim63 commented on August 16, 2024

@uryelah may I have the PR/repo, please?

from linters-config.

uryelah avatar uryelah commented on August 16, 2024

@shshamim63
Origin PR:
jcy2704/tic-tac-toe#1

You can notice in the commits that the student tried adding the extension and it still did not work.

It only worked for them when they commited the changes from a Mac instead of an Windows machine.

from linters-config.

bolah2009 avatar bolah2009 commented on August 16, 2024

Hi @shshamim63 @uryelah
What is the final decision on this?

from linters-config.

uryelah avatar uryelah commented on August 16, 2024

@bolah2009 @shshamim63
Since the command that fixes this( git update-index --chmod=+x .\lib\main) issue is not compatible with Macs and really mostly useful for Windows users,
let's simply add it to the PathWright info on the TicTacTow ruby project Pathwright and maybe as a note to the Ruby linter instructions as mentioned here.

from linters-config.

jcy2704 avatar jcy2704 commented on August 16, 2024

@bolah2009 @shshamim63 @uryelah
I think the best way is to use git update-index --chmod=+x ./bin/main for Windows and maybe for some of Linux, because I installed Linux Ubuntu 20.4 in a old computer and tried and it gives me the same error.

Also sometimes when using git update-index --chmod=+x ./bin/main it throws an error saying that is not found or not accessible then just add --add after --chmod=+x

from linters-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.