Comments (9)
@euqueme @uryelah Can you please check this issue?
from linters-config.
@bolah2009 We could try a matrix strategy to accept multiple versions of ruby. I'll test this out.
name: Ruby CI
on:
push:
branches: [ $default-branch ]
pull_request:
branches: [ $default-branch ]
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: [2.7.x, 2.6.x, 2.5.x]
steps:
- uses: actions/checkout@v2
- name: Set up Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
- name: Install dependencies
run: bundle install
- name: Run tests
run: bundle exec rake
from linters-config.
@IjayAbby Coudl you send a screenshot of the error?
Did you have a .ruby-version
file in the project?
Did both actions fail or just one of them, Rubocop or Rspec.
from linters-config.
It seems that Rubocop runs ok on projects built with ruby version 3 unless there's a .ruby-version
file
from linters-config.
@uryelah if we update the current version of robocop, would that solve this issue?
from linters-config.
@bolah2009 I'm double checking this but I really think just asking students to not commit .ruby-version files would be enough.
from linters-config.
@bolah2009
We could change the rubocop version to 1.9 and accept any ruby version above 2.6.x
What do you think? That seems to work properly.
Ex:
name: Linters
on: pull_request
jobs:
rubocop:
name: Rubocop
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-ruby@v1
with:
ruby-version: ">=2.6.x"
- name: Setup Rubocop
run: |
gem install --no-document rubocop:'~>1.9.0' # https://docs.rubocop.org/en/stable/installation/
[ -f .rubocop.yml ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/ruby/.rubocop.yml
- name: Rubocop Report
run: rubocop --color
from linters-config.
@bolah2009 PR #126 created to add fix for 3.0.0 compatibility.
Please check this when you can.
CC @euqueme
from linters-config.
Merged in #126
from linters-config.
Related Issues (20)
- Confict between liter checks and core react project requirement
- Eslint complains about single named exports
- Please add /dist in line 20 of linters.yml
- Constant : Obsolete linters configuration file
- Ubuntu 18.04 depreciation HOT 1
- Linters config update HOT 1
- Warning: obsolete parameter `IgnoredMethods` in .robocop.yml file
- @-rule issues with plain SASS
- Setup Ruby action deprecation
- Please Update stylelintrc.json to include Tailwind CSS compiled file in 'ignoreFiles' key.
- Should hint linters throw an error on this line?
- Disabling Javascript "Line Break Style" Rule
- Ruby Lintes install
- Warning in rubocop.yml HOT 1
- linters.yml file throws "Lighthouse" error HOT 1
- Remove Template Literal HOT 2
- Linter/Eslint Configuration for React-Redux
- .rubocop.yml HOT 2
- Webhint Error [ERR_REQUIRE_ESM] HOT 4
- HTML & CSS3 Course - please edit
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linters-config.