Comments (6)
Hi,
Thanks for the clarification. AdedayoOpeyemi/Ruby-capstone-project#2 is the link to the Pull request. As stated I had to use the include keyword to make it work.
from linters-config.
Hi @AdedayoOpeyemi, thanks for opening this issue. Is this the PR AdedayoOpeyemi/Ruby-capstone-project#2 to failing GHA?
from linters-config.
Hi @bolah2009, I am not sure I understand your question
from linters-config.
Hi @AdedayoOpeyemi sorry for not clarifying myself. The failed GitHub Action (GHA) that you posted the error messages, am asking which of your Pull request (PR) is the error from?
Would be better to see the whole project for more context.
Thanks
from linters-config.
Okay, thanks @AdedayoOpeyemi
from linters-config.
Hi @AdedayoOpeyemi 👋
I just check the issue you were having, well the way you have generated tests for your modules. actually needs some refactoring. Whenever you are adding tests for modules that are included in a class you should test them by generating the class instance. If you refactor the test suppose for afrer_colon_spec.rb
in the following way it will not generate the error.
require_relative '../lib/after_colon.rb'
require_relative '../lib/linter'
describe AfterColon do
let(:file) { './style.css' }
let(:error_array) { [] }
let(:cont) { File.readlines('./style.css') }
let(:checker) { LinterApp.new }
describe '#after_colon_check' do
it 'returns nil when all the colons on line has the right afterspace' do
expect(checker.after_colon_check(cont[34], 34)).to eql(nil)
end
it 'It returns an error message when the colons do not have the right afterspace' do
checker.after_colon_check(cont[136], 136)
expect(checker.after_colon_check(cont[136], 136)).to eq("\e[0;36;49mNo space after colon on line 137\e[0m")
end
it 'It returns nil if the line passed conly contains a psuedocode' do
expect(checker.after_colon_check(cont[113], 113)).to eq(nil)
end
it 'It returns an error if there is no space after the colon' do
checker.after_colon_check(cont[110], 110)
expect(checker.after_colon_check(cont[110], 110)).to eq("\e[0;36;49mNo space after colon on line 111\e[0m")
end
end
end
This will not render any error while doing linter check. For more info on how to test modules please go through this article
from linters-config.
Related Issues (20)
- Please add /dist in line 20 of linters.yml
- Constant : Obsolete linters configuration file
- Ubuntu 18.04 depreciation HOT 1
- Linters config update HOT 1
- Warning: obsolete parameter `IgnoredMethods` in .robocop.yml file
- @-rule issues with plain SASS
- Setup Ruby action deprecation
- Please Update stylelintrc.json to include Tailwind CSS compiled file in 'ignoreFiles' key.
- Should hint linters throw an error on this line?
- Disabling Javascript "Line Break Style" Rule
- Ruby Lintes install
- Warning in rubocop.yml HOT 1
- linters.yml file throws "Lighthouse" error HOT 1
- Remove Template Literal HOT 2
- Linter/Eslint Configuration for React-Redux
- .rubocop.yml HOT 2
- Webhint Error [ERR_REQUIRE_ESM] HOT 4
- HTML & CSS3 Course - please edit
- Issue on npx hint .
- Outdated Ruby linter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linters-config.