Log Spam with BoP about bedrockores

[fnuecke]

Fixed in 2867bd8 (will be in version 1.1.0).

Thanks for persisting and bearing with me ^^;

[fnuecke]

Are you sure you used the BoP generation setting when testing with BoP only? Because those loggings are just plain old System.out.printlns in their generator, and that has nothing to do with this mod.

[fnuecke]

In fact, there's already an issue on this on their issue tracker, and looks like that doesn't involve Bedrock Ores, as expected.

[Thiana]

Yes, I created the exact same world. With BoP alone, there is no log spam. With BoP+Bedrock Ores, spam. Perhaps @Darkmega18 is also running Bedrock Ores? I dont know if they tested BoP in isolation.

I just reran the tests. Here are the full logs of me creating the world, flying to another island then exiting.

• BoP Only: https://paste.ee/p/udL1e
• Both: https://paste.ee/p/PEtdk

You can see the world settings are identical but with BedrockOres it spams that debug statement 43 times in 11 seconds.

[fnuecke]

Doubtful; and even if Bedrock Ores triggers it somehow, it's still just a plain println call, which is never a good thing to leave in a mod, because it'll always spam the log sooner or later. It's up to BoP to fix this. They probably just forgot to remove that after debugging.

[Thiana]

Adubbz sent me back.

The issue is because Bedrock Ores is repeatedly creating new instances of the chunk generator rather than using the chunkGenerator field in ChunkProviderServer or caching it.

See https://github.com/MightyPirates/BedrockOres/blob/a991d6c920619b36733c5771a29e5bccd07da0ca/src/main/java/li/cil/bedrockores/common/world/Retrogen.java#L100

This is a bug on their side, under normal circumstances this should only ever be called once which is why the println is where it is.

[fnuecke]

Interesting; it's a totally fair point that this should be cached, will fix!
(But I still don't agree with printlns :P)

[Darkmega18]

I was indeed using bedrock ores. but it was occuring even before I had found said mod and installed it.

[fnuecke]

Guess some other mod re-created the IChunkGenerator, too, then. TBF, that shouldn't really be a problem unless BoP is present and logspams :P (it's just less efficient than caching it.) So it's easy to "do it wrong".