Comments (6)
Correct. I'm refectoring sidenav.
Hope it will land on master along with the flex grid.
from ember-paper.
Well, after the sidenav refactoring, this still is a problem.
Any ideas to fix this?
We can't just close the sidenav on any click, right?
What would be a good rationale for the sidenav closing? A manual call? Route change?
from ember-paper.
Personally I think animating out at the beginning of a route change would be a good default but in some situations (can't think of any) the drawer might need to stay open until closed manually. I don't see that the spec gives any direction on it unfortunately...
from ember-paper.
This why I love Ember.
So much beauty in this solution.
When you think that components/views just need to represent the state of a controller, everything is easier.
from ember-paper.
l have a use case where you don't want to close the drawer at all: when an item is not a link but contains sub items, and a click on it is to expand / collapse the sub items. But I think with this approach (or at worst with a slight modification - I have not tried), it is also possible to keep the drawer open if the route does not change
from ember-paper.
This approach basically delegates the drawer closing to the application. Just set open to false or true, whenever you need it.
In the demo app I used The willTransition hook. You don't need to do it in your use case.
I find this very flexible. Very elegant. Very Ember.
from ember-paper.
Related Issues (20)
- Deprecations when upgrading to Ember >= v3.20.x, {{-in-element}} HOT 1
- Paper select errors when menu is closed on ember > 3.17 HOT 3
- Form elements that accept `required` don't set an A11y attribute on the child element
- PaperSelect with selected=0 HOT 1
- Tab Component lacks accessible role="tab"
- Paper Tabs Pagination Always Visible
- Select ARIA violation around not having an accessible name
- paper-menu.item.shouldRenderButton doesn't handle the case when click handler is installed differently HOT 2
- Paper chips component throws an 'focus' error with readOnly property as true
- paper-chips inside paper-form: form is sent and closed when adding new tag (press Enter)
- error when building app with ember-paper HOT 8
- Ghost basic-dropdown-content once paper-menu closed HOT 1
- Remove usage of liquid and any other confusing irrelevant library from the docs
- With this being deprecated, what should we replace it with? HOT 2
- Add support for `renderInPlace` to `PaperSelect`
- Does not install with Ember 4.1.0 HOT 4
- [Embroider:MacrosConfig] the given config from '.../ember-get-config' for packageName 'undefined' is not JSON serializable. HOT 5
- Quest: Ember 4 + Octane HOT 1
- Button HOT 1
- How does the docs site get deployed? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-paper.