Comments (12)
Watch out @nullpainter, that's how they get us! 😉
I'll merge, sort out the releases and the screenshots some time today. Also time to update the website...
from mamesaver.
No stress - I'll be sleeping from now till then 🤣
from mamesaver.
I will try debug this when I'm at my VS2017 machine...
from mamesaver.
I can confirm if I change the turn off display
setting to 1 Min
, then Mamesaver works. Putting back to Never
crashes again.
from mamesaver.
Oops, I also fixed this by making the TimeSpan
nullable. Will create PR for you to look over. Having it nullable and only conditionally create the timer is a bit less hacky than using min/max value.
from mamesaver.
Actually, it'll end up with a merge conflict if I just create a PR. Here's my version of the fix:
nullpainter@c9c42a4
There's logging and no timer creation if there's no sleep configured.
from mamesaver.
Unrelated, but I also added some fixes suggested by VS code analysis in nullpainter@ca5deae
from mamesaver.
Hey @nullpainter I'm happy to accept your fixes - is there some way I can add these manually? Can't you just merge master into your branch and overwrite my changes?
from mamesaver.
Yep, I can do that. Probably be this evening though (so, in around six hours).
from mamesaver.
All done. Sorry about that - I fixed it before I saw that you already had 😁
btw, do you only have two games currently or are you worried about implied copyright issues? Also - and hardly an issue (just me being a little OCD) - but the MAME icon looks a bit gross against your brown. Wondering whether the bog-standard Windows 10 colour scheme may look better for sample screenshots?
from mamesaver.
All done. Sorry about that - I fixed it before I saw that you already had 😁
No prob at all - you were a little quiet so I thought you were busy and I would help you out a bit 😊
btw, do you only have two games currently or are you worried about implied copyright issues? Also - and hardly an issue (just me being a little OCD) - but the MAME icon looks a bit gross against your brown. Wondering whether the bog-standard Windows 10 colour scheme may look better for sample screenshots?
Hah it's my theme on my parallels VM - looks much better with the brownish background I guess. Yeah it's not the best. I wanted to include all the settings as screenshots and some demo ones too. I'll update when I get back to my other laptop - just been a bit busy to sit with it.
I only had 2 roms because I don't really use mame on my mac.
from mamesaver.
No prob at all - you were a little quiet so I thought you were busy and I would help you out a bit 😊
Thanks; appreciated! Defects are shameful so I felt a moral responsibility to fix 😉
from mamesaver.
Related Issues (20)
- Mac port HOT 10
- MAME configuration parsing fails when paths enclosed in speech marks HOT 1
- Generic error message if ROM path not found HOT 3
- Misleading error message if MAME configuration bad
- Crash on shutdown HOT 1
- About tab HOT 1
- Filter mechanical games, improve BIOS identification HOT 2
- Enhancement - game filtering HOT 14
- Linux port
- Sort out build merging repack and release and making installer work again
- Mamesaver.scr - This application could not be started. Do you want to view information about this issue? ... HOT 19
- Old official 64-bit MAME v0.177 doesn't work with MAMEsaver v2.0's game scan. HOT 41
- Need to tell user to restart their MAME Saver after enabling its logging. HOT 1
- MAME Saver v3.0.1's log file didn't roll over after 100 K in my 64bit W7 HPE SP1's %TEMP%\MameSaver\. HOT 1
- Screensaver not working properly anymore since mame 0.223 (possibly earlier) HOT 3
- Error when used with MAME 0.227 HOT 3
- Artwork not showing HOT 7
- Not finding games HOT 5
- Cannot read mame configuration with latest 262 mame release HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mamesaver.