GithubHelp home page GithubHelp logo

Comments (6)

winzig avatar winzig commented on July 26, 2024

Oh, forgot the other part of this. Once I re-orient the device at all, the video preview layer fixes itself: video is oriented the right way, and the black area goes away!

from mtbbarcodescanner.

mikebuss avatar mikebuss commented on July 26, 2024

Hey @winzig - can you share what version of iOS you're using? Are you able to reproduce this issue using the demo project on your phone?

If you have a demo project you could send my way, or if you could modify the MTBBarcodeScanner demo project to produce the same results, that would help.

I haven't seen this on my end yet, but I'll continue trying to reproduce.

from mtbbarcodescanner.

winzig avatar winzig commented on July 26, 2024

Hi @mikebuss, thanks for responding. I thought for sure this was going to be a weird thing specific to my implementation, but luckily I was able to create a simple demo showing the problem. I'm running this on an iPhone 6. In this demo, I simplified it by not forcing the barcode scanner view to be landscape mode, so the behavior is slightly different than described above, but the same basic problems remain:

  1. There's a gap at the bottom edge of the view
  2. The camera appears to be zoomed in, in addition to being cut off.

If you rotate the device in any direction, the problem goes away.

https://github.com/winzig/BarcodeTest

from mtbbarcodescanner.

mikebuss avatar mikebuss commented on July 26, 2024

Thanks for providing the demo project - that was super helpful in debugging this.

I believe the issue is related to how the view is drawn on the screen. It looks like the previewView isn't drawn properly if the MTBBarcodeScanner starts scanning in viewDidLoad. On my device, if you wait a few seconds for the view to redraw, the bar eliminates itself, but what we really want is for the bar never to appear.

If you move the code from viewDidLoad to viewDidAppear, the gap at the bottom edge of the view never appears and everything seems to work as intended. I'll look to see if there's a way to start scanning earlier in the view lifecycle, but for now I think this is your best bet.

Please let me know if that fixes the issue on your end as well!

from mtbbarcodescanner.

mikebuss avatar mikebuss commented on July 26, 2024

The camera appears to be zoomed in, in addition to being cut off.

Forgot to address this. MTBBarcodeScanner sets the camera focal point of interest to be the center of the image, so you'll see a little zooming. The library doesn't currently support a way to set the videoZoomFactor property on the AVCaptureDevice, but I may add that in future versions. Let me know if that's something that would help you and I'll try to fit it in!

from mtbbarcodescanner.

winzig avatar winzig commented on July 26, 2024

This fixed the issue, thanks!

from mtbbarcodescanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.