GithubHelp home page GithubHelp logo

Comments (6)

mikebuss avatar mikebuss commented on July 26, 2024 1

Ok, I created a branch called iOS7-support which is based off v1.9.1 for iOS 7 and has the above fix.

I've also released v2.0.3 with this fix, but that will require iOS 8+. Thanks again!

from mtbbarcodescanner.

navicor90 avatar navicor90 commented on July 26, 2024

I've made the fix (diff is here), but I think that you should create an iOS7-support branch to create the tag 1.9.2, because I started my fix on tag 1.9.1.

from mtbbarcodescanner.

mikebuss avatar mikebuss commented on July 26, 2024

Thank you for finding the fix @navicor90. I will create a pull request with your change, merge it into the main develop branch, release a v2.0.3 (iOS 8+), and then merge the change into a iOS7-support branch based off v1.9.1 for iOS 7 support.

I'll update this ticket when this is all finished!

from mtbbarcodescanner.

navicor90 avatar navicor90 commented on July 26, 2024

can you release v1.9.2( with iOS7 support) or update v1.9.1(if is possible)? then I update my podfile. Thanks!

from mtbbarcodescanner.

mikebuss avatar mikebuss commented on July 26, 2024

I'd prefer not to release a 1.9.2 if we're already officially at 2.0.3, but there is a way around this:

Can you point your Podfile at the iOS7-support branch, like so?

pod "MTBBarcodeScanner", git: '[email protected]:mikebuss/MTBBarcodeScanner.git', branch: 'iOS7-support'

This will get you this fix, and also keep iOS 7 support, even though MTBBarcodeScanner has officially dropped this support in v2.0.0.

from mtbbarcodescanner.

navicor90 avatar navicor90 commented on July 26, 2024

@mikebuss we use podspec file, because we have a pod that wrap your library for many apps. And the podspec file does not allow set the github repo.

from mtbbarcodescanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.