GithubHelp home page GithubHelp logo

Comments (3)

heffalump avatar heffalump commented on August 23, 2024

Playing devils advocate for a second, couldn't the default implementation be moved into core.matrix? (I'm sort of assuming that the persistent vector implementation would be the default, since it would be the only one with no external dependencies.) And if it were moved into core.matrix, there wouldn't be a circular dependency problem.

That said, moving the protocols into a separate namespace is likely the cleanest way to go about this.

from core.matrix.

mikera avatar mikera commented on August 23, 2024

Hmmm actually I'm writing a rough NDArray implementation, so we will have at least 2 default implementation options :-)

Yes we could put everything in core.matrix... though for some reason huge namespaces always feel a bit uncomfortable to me. It feels like sooner or later we will want protocols in a separate namespace. I note that clojure.core does it this way too..... so presumably it's not too absurd an idea!

So we might as well do the separation early rather than let people get confused and start using the protocols directly as part of the public API?

from core.matrix.

mikera avatar mikera commented on August 23, 2024

OK done this and pushes to master.... seems to work pretty well so I think an improvement on average

from core.matrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.