Comments (3)
Playing devils advocate for a second, couldn't the default implementation be moved into core.matrix? (I'm sort of assuming that the persistent vector implementation would be the default, since it would be the only one with no external dependencies.) And if it were moved into core.matrix, there wouldn't be a circular dependency problem.
That said, moving the protocols into a separate namespace is likely the cleanest way to go about this.
from core.matrix.
Hmmm actually I'm writing a rough NDArray implementation, so we will have at least 2 default implementation options :-)
Yes we could put everything in core.matrix... though for some reason huge namespaces always feel a bit uncomfortable to me. It feels like sooner or later we will want protocols in a separate namespace. I note that clojure.core does it this way too..... so presumably it's not too absurd an idea!
So we might as well do the separation early rather than let people get confused and start using the protocols directly as part of the public API?
from core.matrix.
OK done this and pushes to master.... seems to work pretty well so I think an improvement on average
from core.matrix.
Related Issues (20)
- index-max HOT 3
- `fill` does not preserve type
- Exception when `mmul`ing `fill`ed ndarrays
- Numeric types are unexpectedly coerced HOT 1
- TODO: Not yet implemented: for class clojure.lang.PersistentVector HOT 2
- Why is there no mmul! function ? HOT 2
- API documentation is out of date HOT 4
- Uninitialized object exists on backward branch 108 in clojurescript HOT 11
- Typo in persistent_vector.cljc (vector-dot)? HOT 2
- `pm` (pretty print) undefined in clojurescript HOT 1
- what is the purpose of 'unimplemented' function in utils HOT 2
- Matrix element wise multiplication by column vector HOT 1
- where is react native API document? HOT 1
- Warnings of clashes with Clojure 1.11.0 abs. HOT 6
- apache-commons-matrix not playing well with core.matrix? HOT 1
- New release HOT 2
- pm, get-shape are confused by cells containing sequences in NDArray
- Max size of ndarray matrices? HOT 2
- element-wise equality comparison for non-numbers HOT 2
- Feature request: reverse and rotate functions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.matrix.