Bucket creation race about serverless-deployment-bucket

[mayurdanger]

Is it fixed yet ?

[coyoteecd]

@mayurdanger no it is not, it happened to me today with the latest version. I could even see the two "Creating deployment bucket..." lines in the log.

[coyoteecd]

@mikesouza any idea why the plugin uses the validate event to create the deployment bucket?
Subscribing to before:deploy:deploy removes the need for the if-check (the event is called right before deploy, not during package) here: https://github.com/MikeSouza/serverless-deployment-bucket/blob/f02d14e203128eaae58250b893b7be22b8966a0e/lib/index.js#L38-L40

I can submit a PR if you confirm this would work.

[mikesouza]

@coyoteecd For historical context, originally under Serverless v1, the hook before:package:setupProviderConfiguration and then later before:aws:common:validate:validate was used because before:deploy:deploy would not work for a serverless deploy:

Serverless: command = deploy, options = {}
 IN: before:package:cleanup
 IN: before:aws:common:validate:validate
 IN: after:aws:common:validate:validate
 IN: before:aws:common:cleanupTempDir:cleanup
 IN: after:aws:common:cleanupTempDir:cleanup
 IN: after:package:cleanup
 IN: before:package:initialize
 IN: after:package:initialize
 IN: before:package:setupProviderConfiguration
 IN: after:package:setupProviderConfiguration
 IN: before:package:createDeploymentArtifacts
Serverless: Packaging service...
 IN: after:package:createDeploymentArtifacts
 IN: before:package:compileLayers
 IN: after:package:compileLayers
 IN: before:package:compileFunctions
 IN: after:package:compileFunctions
 IN: before:package:compileEvents
 IN: after:package:compileEvents
 IN: before:package:finalize
 IN: before:aws:package:finalize:mergeCustomProviderResources
 IN: after:aws:package:finalize:mergeCustomProviderResources
 IN: before:aws:package:finalize:saveServiceState
 IN: before:aws:common:moveArtifactsToPackage:move
 IN: after:aws:common:moveArtifactsToPackage:move
 IN: after:aws:package:finalize:saveServiceState
 IN: after:package:finalize
 IN: before:aws:common:validate:validate
 IN: after:aws:common:validate:validate
 
  Serverless Error ---------------------------------------
 
  Could not locate deployment bucket. Error: The specified bucket does not exist
 
  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com
 
  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              12.14.1
     Framework Version:         1.83.3 (local)
     Plugin Version:            3.8.4
     SDK Version:               2.3.2
     Components Version:        2.34.9

However, after some preliminary investigation, sometime in v2 it looks like the lifecycle hooks were changed or fixed so that the hook before:deploy:deploy should work now. I'll investigate further.

This is related to #68 which I created after looking into the work required for #60.