GithubHelp home page GithubHelp logo

Comments (6)

TheRealAgentK avatar TheRealAgentK commented on May 30, 2024 1

Yeah, I don't think it'll become an issue there. The root of the problem is in Java 11+ and the changes towards smaller modules instead of a big lump of classes in the JVM. I don't see this happening on Android at the moment.

But it might be an issue for some of the JVM framework providers. I vaguely remember there was something for the Play framework and I'm not sure if there's specific providers for Spring or other platforms that would do their own thing and not fallback to the generic Java provider.

from raygun4java.

TheRealAgentK avatar TheRealAgentK commented on May 30, 2024 1

The Raygun4CFML fix is here:

MindscapeHQ/raygun4cfml@b969861

The difference is - my new method in the CFML provider tracks heap memory and not physical memory anymore. That might or might not be what you'd want to do, but I think that's more useful in a JVM sense anyway.

from raygun4java.

TheRealAgentK avatar TheRealAgentK commented on May 30, 2024

Ping @mduncan26 ...?

from raygun4java.

mduncan26 avatar mduncan26 commented on May 30, 2024

Does this only affect the collection of environment information or does it impact other functionality too? @TheRealAgentK

from raygun4java.

TheRealAgentK avatar TheRealAgentK commented on May 30, 2024

@mduncan26 The code in Raygun4Java is wrapped in try/catch, so it might not manifest to the implementor during collection.

When you look at https://github.com/MindscapeHQ/raygun4java/blob/master/core/src/main/java/com/mindscapehq/raygun4java/core/messages/RaygunEnvironmentMessage.java lines 52 and below, you can see the code that would cause the issue if it wasn't wrapped in try/catch.

So, in a best-case scenario the collected information via the mbean would just not be availvable and missing.

It would probably be better to check for availability of the missing/locked classes at runtime, as outlined (very roughly) IN MindscapeHQ/raygun4cfml#34 (comment)). I haven't tried that in the cfml provider yet, but it'd be good to maybe implement this in the same way consistently across any JVM-based provider.

from raygun4java.

mduncan26 avatar mduncan26 commented on May 30, 2024

Ok cool, so will we need to consider this for Raygun4Android? It's environment info collection looks rather different than both our cold fusion and java SDKs.
https://github.com/MindscapeHQ/raygun4android/blob/master/provider/src/main/java/com/raygun/raygun4android/messages/crashreporting/RaygunEnvironmentMessage.java

from raygun4java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.