GithubHelp home page GithubHelp logo

[1.20.4] ClasspathLocator is no longer disabled in production env, causing OptiFine to crash while installing in the classpath about minecraftforge HOT 3 OPEN

burningtnt avatar burningtnt commented on May 28, 2024
[1.20.4] ClasspathLocator is no longer disabled in production env, causing OptiFine to crash while installing in the classpath

from minecraftforge.

Comments (3)

burningtnt avatar burningtnt commented on May 28, 2024

The removal of the enabled field happended in 6f9f0f0#diff-07e70ca800aaf1bbe0de02598e83c730c98fac2dacfc0e9c7be43c4a66dc27edL27

I'm not sure about whether this change is for some special purposes or not.
In my opinion, once Forge is enabled to load mods from cp, we should keep the behavior same as how we load mods from the mods folder.

from minecraftforge.

LexManos avatar LexManos commented on May 28, 2024

It being enabled at runtime is an intended change. But it does seem I should re-work it to be a two phase system to be sure to not locate things that have already been located such as optifine.

The locations services is still a work in progress as I was trying to clean up the clusterfuck of a codebase/design while breaking as little as possible. I will make another pass when i get some time.

from minecraftforge.

burningtnt avatar burningtnt commented on May 28, 2024

Thanks for you reply.

If any plans about the feature to disable ClasspathLocator locating JARs which contains ITransformationService are made, please let us know.

from minecraftforge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.