GithubHelp home page GithubHelp logo

Comments (4)

whyando avatar whyando commented on August 17, 2024

it's not in the riot docs either!
https://developer.riotgames.com/apis#tft-match-v1/GET_getMatch

from riven.

MingweiSamuel avatar MingweiSamuel commented on August 17, 2024

You can make an issue for Riot here: https://github.com/RiotGames/developer-relations/issues/new?assignees=&labels=&template=bug_report.md&title=%5BBUG%5D%5BDOCS%5D+

I'll just need to add a patch to https://github.com/MingweiSamuel/riotapi-schema and rebuild to fix on this end, will be a half hour

It does seem that older matches didn't have this field (i.e. PBE1_4328907912, really old) so it will be an Option.

from riven.

whyando avatar whyando commented on August 17, 2024

wow brilliant thanks, I've submitted an issue for riot.

would it help you out if I gathered some recent outputs for every tft api?

from riven.

MingweiSamuel avatar MingweiSamuel commented on August 17, 2024

Alright there we go: https://docs.rs/riven/1.3.0/riven/models/tft_match_v1/struct.Info.html#structfield.game_variation

would it help you out if I gathered some recent outputs for every tft api?

Might be worth making https://github.com/MingweiSamuel/riotapi-schema/ do some example-based schema generation given the flaky docs. I also wish I could run TFT endpoints on CI, but currently I can't get a TFT api key. For now I don't have any use for recent outputs.

from riven.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.