mini-profiler removes cache-control header about rack-mini-profiler

[momelnyk]

+1

[pusewicz]

https://github.com/MiniProfiler/rack-mini-profiler/blob/master/lib/mini_profiler/profiler.rb#L371

This is why. I think this should be only applied to the requests made to fetch mini profiler data.

[SamSaffron]

You can't profile stuff properly if its cached, not following why this is such a big issue, only impacts admins anyway.

[teoulas]

If you deploy on Heroku and follow their recommendation to serve assets from your Rails app with a CDN in front of it, then your CDN will never cache any assets, since mini-profiler overwrites the Cache-Control header. This is easily fixed by configuring the skip_paths option to skip any asset paths. However, it took me ages to debug and find out. Maybe it would be a good idea to skip /assets/ by default?

[SamSaffron]

sure I am happy to add something like this to the railstie if you want to
give it a shot.

On Fri, Aug 14, 2015 at 2:20 AM, Theodoros Orfanidis <
[email protected]> wrote:

If you deploy on Heroku and follow their recommendation to serve assets
from your Rails app
https://devcenter.heroku.com/articles/rails-4-asset-pipeline#serve-assets
with a CDN in front of it, then your CDN will never cache any assets, since
mini-profiler overwrites the Cache-Control header. This is easily fixed by
configuring the skip_paths option to skip any asset paths. However, it
took me ages to debug and find out. Maybe it would be a good idea to skip
/assets/ by default?

—
Reply to this email directly or view it on GitHub
#63 (comment)
.