Comments (3)
This driver, however, exposes arguments[0] instead.
This driver avoids the extra step and simply passes valid JS code directly for execution (the invalid syntax warnings was one of the motivations to remove it).
I think, that this also is a BC break,
It can't be so since this is an entirely new package.
because developers now can't switch to this driver without replacing {{ELEMENT}} across their test suite first.
Why is this in any test suite? This is an internal detail of the driver. In Selenium2Driver, executeJsOnElement
is private and none of its usages allow modifying the code from a public method (as far as I can see). DriverInterface
does not expose a way to execute javascript for an element.
In fact, when we remove syn, most of these usages will also be gone.
But maybe I'm missing something - let me know if you have a specific use case in mind.
from webdriver-classic-driver.
You're absolutely correct. The \Mink\WebdriverClassDriver\WebdriverClassicDriver::executeJsOnElement
is an internal driver method, that isn't forced to obey {{ELEMENT}}
replacement logic.
I must be looking at too much code today, that I haven't noticed that. I honestly thought it was a public method.
My apologies once again.
from webdriver-classic-driver.
No worries!
from webdriver-classic-driver.
Related Issues (13)
- Update readme HOT 1
- Replace syn.js HOT 2
- Add default capabilities for a Firefox HOT 2
- Support switching to frame by index HOT 5
- Improve test coverage HOT 1
- Connect this driver to the "Behat\MinkExtension" project HOT 5
- Rename driver/test namespaces in the PHP files HOT 2
- Fix driver namespace
- Why the clearing approach of "setValue" method was changed compared to the Selenium2 driver? HOT 7
- Move test web server startup/shutdown to the GitHub Actions workflow HOT 2
- The `Session::reset` closes main window, when window was renamed
- The `Session::reset` throws an exception when main window has name HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webdriver-classic-driver.