GithubHelp home page GithubHelp logo

Comments (3)

uuf6429 avatar uuf6429 commented on June 16, 2024

This driver, however, exposes arguments[0] instead.

This driver avoids the extra step and simply passes valid JS code directly for execution (the invalid syntax warnings was one of the motivations to remove it).

I think, that this also is a BC break,

It can't be so since this is an entirely new package.

because developers now can't switch to this driver without replacing {{ELEMENT}} across their test suite first.

Why is this in any test suite? This is an internal detail of the driver. In Selenium2Driver, executeJsOnElement is private and none of its usages allow modifying the code from a public method (as far as I can see). DriverInterface does not expose a way to execute javascript for an element.
In fact, when we remove syn, most of these usages will also be gone.

But maybe I'm missing something - let me know if you have a specific use case in mind.

from webdriver-classic-driver.

aik099 avatar aik099 commented on June 16, 2024

You're absolutely correct. The \Mink\WebdriverClassDriver\WebdriverClassicDriver::executeJsOnElement is an internal driver method, that isn't forced to obey {{ELEMENT}} replacement logic.

I must be looking at too much code today, that I haven't noticed that. I honestly thought it was a public method.

My apologies once again.

from webdriver-classic-driver.

uuf6429 avatar uuf6429 commented on June 16, 2024

No worries!

from webdriver-classic-driver.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.