GithubHelp home page GithubHelp logo

Comments (7)

buschtoens avatar buschtoens commented on June 12, 2024

Also happens with ember build --environment production

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

Steps to reproduce:

  1. Install newest ember-cli version (0.1.4) with npm i -g ember-cli
  2. ember new test-app
  3. cd test-app
  4. npm i --save-dev ember-inline-svg
  5. ember serve

from ember-inline-svg.

rlivsey avatar rlivsey commented on June 12, 2024

I've seen this if there are no SVGs in the directory it's watching, or if that directory doesn't exist.

I think it's an issue in broccoli-spelunk / spelunk itself which we're using to build the manifest, it doesn't resolve the promise so broccoli hangs.

Does the issue go away for you if you add some SVGs?

I definitely want to fix this, either here or in spelunk, but I haven't had a chance to dig too deep into it as of yet.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

Thanks for the reply!

The problem goes away after adding an .svg file to public/images/**. I'm stating that explicitly here, because I didn't know that ember-inline-svg by default expects all .svgs to be located at this path. See #2.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

This is "solved" by #7.

broccoli-spelunk didn't pass on Promise rejections, thus stalling the build. With #7 applied the following error is displayed and the build process is aborted:

Path or pattern "**/*.svg" did not match any files

However, this might not be the desireable behaviour. I would expect the build pipeline to just move on and emit an empty svg.js like:

export default {}

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

This behaviour / error is caused by broccoli-static-compiler and is marked as by design.

There's a plugin called broccoli-funnel which doesn't have this problem. I fixed it and appended it to #7.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

Fixed by #7.

from ember-inline-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.