Comments (7)
Also happens with ember build --environment production
from ember-inline-svg.
Steps to reproduce:
- Install newest
ember-cli
version (0.1.4) withnpm i -g ember-cli
ember new test-app
cd test-app
npm i --save-dev ember-inline-svg
ember serve
from ember-inline-svg.
I've seen this if there are no SVGs in the directory it's watching, or if that directory doesn't exist.
I think it's an issue in broccoli-spelunk / spelunk itself which we're using to build the manifest, it doesn't resolve the promise so broccoli hangs.
Does the issue go away for you if you add some SVGs?
I definitely want to fix this, either here or in spelunk, but I haven't had a chance to dig too deep into it as of yet.
from ember-inline-svg.
Thanks for the reply!
The problem goes away after adding an .svg
file to public/images/**
. I'm stating that explicitly here, because I didn't know that ember-inline-svg
by default expects all .svg
s to be located at this path. See #2.
from ember-inline-svg.
This is "solved" by #7.
broccoli-spelunk
didn't pass on Promise rejections, thus stalling the build. With #7 applied the following error is displayed and the build process is aborted:
Path or pattern "**/*.svg" did not match any files
However, this might not be the desireable behaviour. I would expect the build pipeline to just move on and emit an empty svg.js
like:
export default {}
from ember-inline-svg.
This behaviour / error is caused by broccoli-static-compiler
and is marked as by design.
There's a plugin called broccoli-funnel
which doesn't have this problem. I fixed it and appended it to #7.
from ember-inline-svg.
Fixed by #7.
from ember-inline-svg.
Related Issues (20)
- htmlSafe import is causing error in production build HOT 2
- Upgrade Ember.js tracking plan
- Assertion Failed: No SVG found in production / staging HOT 3
- Option to pass styles through the `style` attribute HOT 4
- Babel Deoptimization HOT 1
- Feature Request: Co-locate SVGs within pods HOT 2
- Passing a class to the inline-svg helper overwrites existing classes on the SVG element HOT 1
- Cannot read property 'filter' of undefined
- Fails to find SVG's imported with ember-cli-node-assets addon
- Silently fails with fingerprinted SVGs HOT 4
- Pull from Absolute Path
- Option to receive an action
- Deprecation Warning when updating to ember 2.18.2
- Update SVGO HOT 2
- Would like an option to override the default JS outputFile (currently, 'svgs.js')
- High and Moderate security issues found in yarn audit HOT 1
- Huge number of security issues found in ember-inline-svg HOT 1
- Why is viewBox property removed from svg file? HOT 1
- Convert to component? HOT 2
- SVGs should be bundled to vendor.js instead of app.js
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-inline-svg.