GithubHelp home page GithubHelp logo

Comments (6)

buschtoens avatar buschtoens commented on June 12, 2024

This is the .svg that produced the error: https://gist.github.com/buschtoens/4b82243b955eb8e0b1cc

As it turns out, I accidentally malformatted the file (line 17). ember-inline-svg should throw a descriptive error in this case and not silently insert an undefined.

from ember-inline-svg.

rlivsey avatar rlivsey commented on June 12, 2024

Good catch, if svgo fails to optimize then I agree we should fail loudly with an informative error.

I was thinking we could fall back to the original unoptimized SVG, but that would just mask the problem so the error is a better idea.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

So far I got Broccoli to throw a descriptive error and everything - in theory.

broccoli-spelunk seems to not support Promises, effectively destroying any error handling. If I remove flattenFolder from the pipeline, I get the expected Errors. With flattenFolder however, the build just stalls and runs forever.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

I see you've written broccoli-concat. It should be possible to fork it and make it do what spelunk is supposed to do.

Your plugin supports Promises.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

I'm modding broccoli-json-concat.

from ember-inline-svg.

buschtoens avatar buschtoens commented on June 12, 2024

Got it working. I'll release a new npm package and submit the PR.

from ember-inline-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.