GithubHelp home page GithubHelp logo

Comments (6)

miqwit avatar miqwit commented on August 21, 2024

Hello @ignacioalles. Thank you in your interest for this repository.

The PartyList is covered already. It can be "zero to many" and hence is part of DedexBundle\Entity\Ern41\NewReleaseMessage, in property partyList. It can be accessed with function addToPartyList.

Now, of course this should be called and populated automatically. I did not add a comprehensive test suite for ERN 4.1 (opposedly to 3.8.1 that I use more often). Could you help me reproducing your issue by providing me the ERN 4.1 that you are working on, maybe by anonmyzing it's content (unique IDS and names).

Thanks for your help and your interest.

from dedex.

miqwit avatar miqwit commented on August 21, 2024

As an additional note, I am not (yet) keen to approve your PR, because the entities are automatically generated by the tool xsd2php, hence I don't want to modify them manually, but rather understand why it's not parsed properly.

from dedex.

ignacioalles avatar ignacioalles commented on August 21, 2024

Hi @miqwit
I've used some xml derived from ERN 4.1.1 provided samples (only changed namespace to match ERN 4.1). I could not find actual 4.1 samples.

The same problem occurs in DealList > ReleaseDeal.
I've added a very basic test case in PR. Perhaps you can take it from there.

It seems that generated classes expects document to be:

<PartyList>
         <PartyReference>PSaekoShu</PartyReference>
         <PartyName>
            <FullName>Saeko Shu</FullName>
            <FullNameIndexed>Shu, Saeko</FullNameIndexed>
         </PartyName>
         <PartyName LanguageAndScriptCode="ja-Jpan">
            <FullName>しゅうさえこ</FullName>
         </PartyName>
 </PartyList>
 <PartyList>
         <PartyReference>PEMI</PartyReference>
         <PartyName>
            <FullName>EMI MUSIC JAPAN INC.</FullName>
         </PartyName>
</PartyList>

instead of

<PartyList>
      <Party>
         <PartyReference>PSaekoShu</PartyReference>
         <PartyName>
            <FullName>Saeko Shu</FullName>
            <FullNameIndexed>Shu, Saeko</FullNameIndexed>
         </PartyName>
         <PartyName LanguageAndScriptCode="ja-Jpan">
            <FullName>しゅうさえこ</FullName>
         </PartyName>
      </Party>
      <Party>
         <PartyReference>PEMI</PartyReference>
         <PartyName>
            <FullName>EMI MUSIC JAPAN INC.</FullName>
         </PartyName>
      </Party>
</PartyList>

but the first document does not pass xsd validation: Error: XMLReader::read(): Element 'PartyReference': This element is not expected. Expected is ( Party ).

from dedex.

miqwit avatar miqwit commented on August 21, 2024

Hello @ignacioalles. I am still working on it. I made some progress in branch ddex411 but still some tests fail.

It is not related to DDEX 4.1.1 in fact, but to a special case in DDEX modelling (from XSD) where some List tags, such as PartyList (which is new to DDEX 4.1.1) or ReleaseResourceReferenceList (which is not new but is badly ignored in current version) that do not have a specific class in the model. They are just a list of objects attached to parent node, in fact. And the parser does not support it yet.

Soon! Be patient (and try my branch if you want).

from dedex.

miqwit avatar miqwit commented on August 21, 2024

Hello @ignacioalles I fixed it in branch ddex411 which is now merge to master. Check the last version!

from dedex.

ignacioalles avatar ignacioalles commented on August 21, 2024

Sorry for the late reply. I can confirm it works fine with our testing files.

from dedex.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.