Comments (3)
Dear @copy:
so the compatible versions can be changed from
ppx_sexp_conv < v0.11.0
toppx_sexp_conv != v0.11.0
I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto
nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.
I checked that x509 is compilable with newer versions of ppx_sexp_conv (and doesn't suffer from the same bug that nocrypto suffers from).
I'm not exactly sure what you mean. I hope my description above sheds some light into why X.509 (and tls) are restricted to ppx_sexp_conv {< "v0.11.0"}
at the moment.
I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv. I hope this works fine for you.
from ocaml-x509.
fixed in #109
from ocaml-x509.
I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.
You're right about this. Originally I was under the impression that simply adding ppx_sexp_conv
to the META
file would work for both ppx_sexp_conv<v0.11.0and
ppx_sexp_conv>=v0.11.0, but that doesn't seem to be the case.
I'm not exactly sure what you mean.
I was referring to the original issue here: mirleft/ocaml-nocrypto#143, which is not related to Nocrypto's META files but to its build system (see mirleft/ocaml-nocrypto@ee7305f and mirleft/ocaml-nocrypto@a9da8a8). I simply stated that x509 doesn't suffer from this problem.
I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv.
Very much appreciated.
from ocaml-x509.
Related Issues (20)
- parsing pem from string HOT 2
- Incompatible with sexplib/ppx_sexp_conv v0.11.0 HOT 6
- API woes HOT 1
- Invalid_argument "X509: failed to parse certificate" when using X509.Encoding.Pem.Certificate.of_pem_cstruct1 HOT 3
- Expose X509.Certificate.compare HOT 2
- Issues with the DN representation HOT 22
- Certificate verification allows dangerous algorithms HOT 8
- Why is Validation.trust_cert_fingerprint deprecated? HOT 3
- improve API (make it harder to use wrong) HOT 2
- feature: ed25519 support HOT 7
- feature: ed448 support HOT 1
- mirage-crypto 0.8.9 breaks regression test HOT 7
- feature: enhance Private_key module HOT 1
- [Public_key.verify]'s ECDSA evaluation mishandles long digests HOT 11
- Add hostnames: csr -> string list for obtaining list of domains of a csr. HOT 2
- Retrieving valid_from/valid_until from a certificate HOT 1
- missing `astring' in META HOT 2
- How to access some parts of a certificate HOT 1
- Cannot install due to dependency problem HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocaml-x509.