GithubHelp home page GithubHelp logo

Comments (3)

hannesm avatar hannesm commented on July 28, 2024

Dear @copy:

so the compatible versions can be changed from ppx_sexp_conv < v0.11.0 to ppx_sexp_conv != v0.11.0

I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.

I checked that x509 is compilable with newer versions of ppx_sexp_conv (and doesn't suffer from the same bug that nocrypto suffers from).

I'm not exactly sure what you mean. I hope my description above sheds some light into why X.509 (and tls) are restricted to ppx_sexp_conv {< "v0.11.0"} at the moment.

I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv. I hope this works fine for you.

from ocaml-x509.

hannesm avatar hannesm commented on July 28, 2024

fixed in #109

from ocaml-x509.

copy avatar copy commented on July 28, 2024

I'm sure this will lead to invalid metadata (in the META file of X.509) due to ppx_sexp_conv introducing run-time dependencies. This is hard to observe (by using opam) since nocrypto nowadays already adds the required depedencies into their META file and shadows the insufficient data in X.509 META file.

You're right about this. Originally I was under the impression that simply adding ppx_sexp_conv to the META file would work for both ppx_sexp_conv<v0.11.0andppx_sexp_conv>=v0.11.0, but that doesn't seem to be the case.

I'm not exactly sure what you mean.

I was referring to the original issue here: mirleft/ocaml-nocrypto#143, which is not related to Nocrypto's META files but to its build system (see mirleft/ocaml-nocrypto@ee7305f and mirleft/ocaml-nocrypto@a9da8a8). I simply stated that x509 doesn't suffer from this problem.

I'll merge #109 and release X.509 for compatibility with newer ppx_sexp_conv.

Very much appreciated.

from ocaml-x509.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.