Allow Picture-in-Picture on mobile devices about mirotalk

[miroslavpejic85]

Hi @chengyuhui,
Hope you're doing well! 😊 Would you mind sending a pull request?
Thanks a bunch!

[miroslavpejic85]

Good, I just fix a typo.

document.pictureInPictureEnabled already returns a boolean, then using double negation (!!) is indeed unnecessary. In such a case, you can directly use the boolean value returned by document.pictureInPictureEnabled without any additional conversions.

Thank you!

[miroslavpejic85]

Tested to be working on latest mobile Chrome (simply removing !isMobileDevice works).

But I'm not able to make it work on real mobile device in Chrome, and other browsers as well :)

I recall now that Document PIP and Video PIP doesn't work on real mobile devices.

That's why I implemented the filter !isMobileDevice

[chengyuhui]

Just tested again on my Samsung S23 with Chrome 120.0.6099.144, video PiP worked fine. Note that Firefox does not support these APIs at all.

Document PiP isn't even available on mobile devices, if memory serves me right.

[miroslavpejic85]

You are right in this device works and maybe also in some other, while in some not, although document.pictureInPictureEnabled return true, in the browser logs got:

Failed to enter Picture-in-Picture mode: NotSupportedError: The video element does not support the Picture-in-Picture mode.

Let me thinking, I will push asap.

[miroslavpejic85]

Now you will be able to use PIP video on Mobile devices. In case your device doesn't support this feature for some reason, a helpful popup message will appear, and the button will be hidden.