GithubHelp home page GithubHelp logo

Comments (7)

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

Hi and thank you for reporting this! I just confirmed that the bug can be reproduced:

Screenshot from 2022-12-16 23-48-43
Screenshot from 2022-12-16 23-48-50

I'm not sure why would CSGCombiner behave differently than a normal Spatial node. I'll check this and let you know ;)

from godot-array-modifier.

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

It seems that the problem might be caused by the scene tree structure rather than by node types. Specifically, I discovered that ArrayModifier has to be a direct child of a root node. So,

Spatial => ArrayModifier => MeshInstance

works, but

Spatial => Spatial => ArrayModifier => MeshInstance

doesn't (in the exact way that you described). Perhaps it's a problem with the implementation of add_child_below_node, but maybe there is something wrong with my code. I'll keep you posted ;)

from godot-array-modifier.

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

I changed the code a bit to add the child nodes to the root instead of the direct parent, and the nodes appeared in the editor. So, this is most likely a bug with the implementation of add_child_below_node. I will ran some extra tests next week, and submit an issue to Godot's team ;)

from godot-array-modifier.

TheConceptBoy avatar TheConceptBoy commented on June 26, 2024

I changed the code a bit to add the child nodes to the root instead of the direct parent, and the nodes appeared in the editor. So, this is most likely a bug with the implementation of add_child_below_node. I will ran some extra tests next week, and submit an issue to Godot's team ;)

Ahh roger. Well that's good to hear at least. Will you be pushing the change to the godot Asset Library plugin or is github going to be the place to get the updated plugin for the time being?

from godot-array-modifier.

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

OK, I think that using self.owner instead of parent solves the problem :) I've pushed the changes already in 646fc9b (the next commit contains some changes applied automatically by a new version of Godot).

I've also submitted a new version to the Asset Library:
https://godotengine.org/asset-library/asset/edit/6757

While my plugin is waiting for approval, you can use the code from this repository directly (the change is not a big one). Please let me know if this solves your problem, I will keep this issue open until then ;)

from godot-array-modifier.

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

Hi @TheConceptBoy ! Did you get a chance to test the new version? Does it fix the problem? ;)

from godot-array-modifier.

miskatonicstudio avatar miskatonicstudio commented on June 26, 2024

I am closing this issue. If you still experience problems, please reopen or create a new one ;)

And thank you again for reporting this! It fills me with pride that my tool makes someone's life easier, and every time an issue is spotted, it's a chance to make my code better ;)

from godot-array-modifier.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.