[Bug] hideDisabled is not working in to_svg() function about mitreattack-python

[azkasadaf]

sure,
thanks for the quick response!
here is the layer's json I'm using to generate the above SVG

[azkasadaf]

Hi @clemiller I just checked with version 12 and it's working like a charm.

Although the legend is still an issue, but I guess I'll work for a while with it pinned to the header.
As for the font size I'll look into the update you've mentioned.
Thanks for the update.

[clemiller]

This issue was addressed in PR #95. Let us know if you still run into any problems.

[azkasadaf]

Hi,

I just checked the update; and it's working quite well (highly appreciate the efforts) but (sadly) it's not yet completely fixed

Expected SVG

Actual SVG

• some fields are still showing in the final SVG regardless of the fact that hideDisabled is set to True in json config
• in addition to that the legend is not appearing if it's NOT pinned to the header and there is visible irregularity in the font size as well

[clemiller]

Hi @azkasadaf,

Thank you for letting us know! I will look into this further. Would you be able to provide a link to the layer that is rendering incorrectly? Thanks!

[azkasadaf]

Hi,
I wanted to ask if there is any update on the issue so far?

[clemiller]

Hi @azkasadaf,

Apologies for the delay in response! The discrepancy with techniques in your SVG appears to be caused by an outdated layer file (ATT&CK v10). The techniques that are unexpectedly appearing in your SVG are techniques which have been added or modified since ATT&CK v10 (the ATT&CK version of your layer file), so it looks like the Matrix is being generated from the latest ATT&CK v12.

For example, Serverless Execution (T1648) is displayed because enabled is not set to false for T1648 in either example layer files you provided. This technique was added in ATT&CK v12.

I'd recommend upgrading your layer file to v12 or checking the ATT&CK version that is being used to generate the underlying Matrix in the ToSvg() function. You can download the enterprise-attack.json file from the ATT&CK v10.1 Release and use the local file to generate the underlying matrix with v10:

from mitreattack.navlayers import Layer, ToSvg

lay = Layer()
lay.from_file("layer.json")

svg = ToSvg(domain='enterprise', source='local', resource='enterprise-attack-v10.1.json')
svg.to_svg(layerInit=lay, filepath="layer.svg")

As for the issue with the legend- there is a bug in how the legend is generated when legendDocked is false and some inconsistency with the font sizes. We are currently working on a fix for this. The font size has been a bit of an ongoing issue in the Navigator. We've made some adjustments in the past (see Navigator#394) for more consistency, but these changes have not been reflected in the Python library.