Default theme: N and P keys no longer work about mkdocs

[squidfunk]

Fix in #3729. Also note that #3694 has not been released yet.

[squidfunk]

Another problem: When you click on the "User guide" and "Developer guide" tabs, an error is triggered in the console. Fixed in #3730. Note that we normally would use optional chaining, but I'm not sure which browsers MkDocs wants to support, so I'm going for a good ol' conditional branch.

[squidfunk]

@tomchristie friendly ping ☺️ would be great to have those fixes released 🚀

[pawamoy]

Sounds like it comes from the move from JQuery to vanilla Javascript. Tagging @squidfunk.

[nandoflorestan]

I am impressed by how quickly a solution was presented. Thank you! Hoping for a point release of mkdocs soon.

[squidfunk]

Yes, a release would be great! Looking at the changeset, it looks like a patch release would follow semantic versioning, except maybe for changing the output of sitemap.xml, but changefreq is a no-op for search engines anyway. Thus, 1.6.1 should be good to go, even after merging #3729 and #3730, as no change adds new or breaks existing behavior ☺️

Let's hope the maintainers also see it that way ☺️

[squidfunk]

Thanks! However, as I mentioned in #3728 (comment), #3730 was only bycatch, so this issue, IMHO, cannot be considered resolved and should be reopened, since the corresponding fix was not merged yet. The relevant PR is #3729.