GithubHelp home page GithubHelp logo

Comments (6)

LucidNinja avatar LucidNinja commented on May 22, 2024 1

Actually, that can be fixed by adding the -webkit-mask-image property, as referenced here: https://gist.github.com/ayamflow/b602ab436ac9f05660d9c15190f4fd7b

from react-parallax-tilt.

mkosir avatar mkosir commented on May 22, 2024 1

Hey @LucidNinja, thanks for the PR, it looks great, I already merged it and created new release 1.5.0 🚀

from react-parallax-tilt.

LucidNinja avatar LucidNinja commented on May 22, 2024

Actually, even if I add the following:

.glare-wrapper {
  border-radius: 3rem;
}

There seems to be a bug in Safari both on desktop and iOS that causes square corners to show momentarily, before disappearing. Not sure why this is? I'll have a look into it further to see if a CSS bug?

from react-parallax-tilt.

mkosir avatar mkosir commented on May 22, 2024

Hi @LucidNinja thanks for the detailed bug report and provided possible solution(s) 🚀
As you mentioned this can be added as css prop to .glare-wrapper class, but I would prefer the second option you proposed, passing it as a GlareBorderRadius prop?
I think if we add the prop to styleGlareWrapper object in /src/features/glare/Glare.ts it should work.
Would you like to take a stab at this and create PR?

from react-parallax-tilt.

LucidNinja avatar LucidNinja commented on May 22, 2024

Ok I can give it a go!

from react-parallax-tilt.

LucidNinja avatar LucidNinja commented on May 22, 2024

Hey @mkosir - adding the GlareBorderRadius prop to the styleGlareWrapper would have required me to change the constructor (from what I can see), so I created a private method inside Glare.tx and ran it during the render method. Not sure if that's the best way to tackle it, but it works. Let me know if you have any feedback. See #28

from react-parallax-tilt.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.