GithubHelp home page GithubHelp logo

Comments (13)

Datamance avatar Datamance commented on July 17, 2024 6

Huge +1 to this. Would be amazing to not have to drop back to numpy/CPU for these sorts of things.

from mlx.

awni avatar awni commented on July 17, 2024 4

Something like np.linalg.norm for vectors and for a matrix Frobenius norm should be very easy to do.. that's also a good place to start just to get the packaging setup.

from mlx.

awni avatar awni commented on July 17, 2024 3

We would love to have these operations available directly in MLX. It's not our top top priority but something we intend to add in the future or even better accept contributions for.

If you are interested in contributing, here are some thoughts:

  • To the extent that we can avoid writing these from scratch that is good.
  • For the CPU we can use LAPACK and/or Accelerate depending on what's available in each. A good starting point would be to wrap an op from one of those just for the CPU (and throw for the GPU).
  • On the GPU there are also some pre-written kernels we can use from MPS for example: (cholesky)[https://developer.apple.com/documentation/metalperformanceshaders/mpsmatrixdecompositioncholesky?language=objc].
    You can see an example of how to wrap MPS matmul. The others could be done similarly.
  • For ops not supported by MPS, we'd need kernels which is a bigger project, but a fun one for those up for a challenge!

from mlx.

nullhook avatar nullhook commented on July 17, 2024 2

matrix factorizations aren't easy parallelizable on the gpu.

would QR and SVD only have cpu implementation for now? @awni

from mlx.

awni avatar awni commented on July 17, 2024 1

So you can look at how mlx.core.random works. We could do something similar for mlx.core.linalg. Basically it's a nested namespace on the C++ side mlx::core::random and then we make it a submodule in the pybind11 bindings. Then you can do:

import mlx.core as mx
mx.linalg.< >

from mlx.

gboduljak avatar gboduljak commented on July 17, 2024 1

Any thoughts on implementing at least vector/matrix norm methods such as torch.linalg.vector_norm?

from mlx.

nullhook avatar nullhook commented on July 17, 2024 1

note to self: almost all LAPACK routines are col-major

@awni would Transpose on an mlx array before sending it to LAPACK routines work here, or is there an alternative way?

from mlx.

ivanfioravanti avatar ivanfioravanti commented on July 17, 2024 1

matrix factorizations aren't easy parallelizable on the gpu.

would QR and SVD only have cpu implementation for now? @awni

SVD support would be great.

from mlx.

awni avatar awni commented on July 17, 2024 1

The CPU versions of these are pretty doable. See the QR factorization as an example https://github.com/ml-explore/mlx/blob/main/mlx/backend/common/qrf.cpp

GPU support is more involved as I don’t think there are many open source Metal implementations

from mlx.

aymuos15 avatar aymuos15 commented on July 17, 2024

Hi! I am quite interested to work on this but not really sure how to start. Would someone be able to push me in the right direction?

I would be even open to have a short meeting if required.

I work from a M2 Max. Thank you :)

@awni

from mlx.

j-csc avatar j-csc commented on July 17, 2024

Thoughts on wrapping these linalg specific functions to a separate module on Python frontend?

from mlx.

awni avatar awni commented on July 17, 2024

No I wouldn't deal with that using a transpose. You can usually call the routine with the right arguments and avoid a transpose. For example a row-major [M, N] matrix is the same as a col major [N, M] matrix in terms of its memory layout.

from mlx.

rickypang0219 avatar rickypang0219 commented on July 17, 2024

Hi @awni, may I ask is there any learning resources of Apple Metal and Accelerate Framework? I want to contribute to LinAlg module but I do not know where to start with. For instance, if I want to build mx.linalg.eig , how can I use LAPACK from apple accelerate framework?

from mlx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.