More losses! about mlx

[awni]

Definitely! L1 and MSE for sure. I would also add a binary cross entropy as well.

We already started a loss module here but it has no docs yet.

Some testing + docs for any additional losses would be fantastic.

Also, what's the distinction between the nll_loss and the cross_entropy loss we already have?

[h-0-0]

Hi, I'll implement the L1 and MSE losses in that case, and you are correct about the negative log likelihood! I was just going through the pytorch losses and thinking about which would be the most helpful to add. Of course I'll add docs and testing aswell.

[awni]

There have already been contributions for L1 and MSE. You can see the referenced PRs in this issue to see what's been/being added.

If there are other common losses you'd like to add, feel free to let us know and we can discuss here.

[awni]

All the losses in this issue have been pushed to main so I will close it. Feel free to open a new issue for new losses.