GithubHelp home page GithubHelp logo

Comments (9)

nvcforster avatar nvcforster commented on June 15, 2024

See also #84

from training.

lucienwang1009 avatar lucienwang1009 commented on June 15, 2024

OK, didn't see it before. Feel free to close this issue.

from training.

nvcforster avatar nvcforster commented on June 15, 2024

Hi Lucien (@lucienwang1009 ), I wanted to link the two issues. Your finding makes it more urgent to update the TF version specified in the Dockerfile.

from training.

bitfort avatar bitfort commented on June 15, 2024

This is unfortunate. Thank for for letting us know. If this is blocking you, feel free to link a PR here and I'll take a look at it. Otherwise we will try to address this in the coming days.

from training.

lucienwang1009 avatar lucienwang1009 commented on June 15, 2024

I agree with @nvcforster that it ought to use a stable version rather than an alterable nightly one. Besides, I prefer providing variables in Dockerfile to assign versions of TF, CUDA, and CUDNN etc.
By the definition, a reference result is the quality or the performance of a benchmark running in a system with a framework. So the Dockerfile, as a definition of the system environment, should provide a way to specify these software versions.

Anyway, I really want you guys to consider and address this issue ASAP, at least stick to an available stable version.
BTW: in translation benchmark, tf-nightly-gpu is installed again in docker container, which is obviously redundant.

from training.

David-Levinthal avatar David-Levinthal commented on June 15, 2024

could somebody at least post a functioning edit for the dockerfile line?
RUN pip3 install --upgrade numpy scipy sklearn tf-nightly-gpu==1.9.0.dev20180419

from training.

bitfort avatar bitfort commented on June 15, 2024

I'll take a look at this in the next day or two... sorry for the issue here.

In the mean time, one option is taking a look at the source of this fork:
https://github.com/tensorflow/models/tree/master/official/transformer

The "official" version will be very similar (since we forked it with only minor modification) and better maintained, it may give insight into these kinds of problems.

from training.

bitfort avatar bitfort commented on June 15, 2024

PTAL #119

from training.

johntran-nv avatar johntran-nv commented on June 15, 2024

Closing because GNMT is deprecated from the benchmark suite.

from training.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.