[Summer 2021] Investigate SQL exception raised by SAPP server about pyre-check

[abishekvashok]

@r0rshark it happens, as mentioned in the exception, when one sqlite3 db connection is used by multiple threads. As long as we performs mutations atomically, we should be good for this solution here: https://stackoverflow.com/a/48234567

ie,
suppress the exception(s).

How does that sound, or should we recreate the connection each time?

[r0rshark]

https://stackoverflow.com/a/48234567

Got it I am still not sure about which are the two threads. My guess is that one is the thread of the main application where the db is created https://github.com/facebook/sapp/blob/master/sapp/ui/server.py#L65 and the other one is the flask server running. In this case I guess it should not be a problem since all the mutation happen in the flask application

[abishekvashok]

Yeah my assumption is the same. Making a PR :)

[abishekvashok]

Closed via facebook/sapp@bc72d51