Comments (11)
It only affects CMYK with 8-bit integer depth, 16-bit and float appear to be unaffected.
from little-cms.
Hello,
I cannot reproduce this with tificc. Could you please give me more details?
Specifically:
- the profile is used as input or output?
- which intent?
- any special flags, black point compensation?
- to which / from which profile are you doing the transform?
I used from/to built-in sRGB:
tificc -t0 -i AP_Munken_Print_White_260v4.1.icm ramps_cmyk.tif out-14-rgb.tif
tificc -t0 -o AP_Munken_Print_White_260v4.1.icm ramps.tif out-14-cmyk.tif
Both gives same result as 2.13.1
Probably I am missing something important.
from little-cms.
Checked other intents too, and BPC as well. All works fine to me.
from little-cms.
the profile is used as input or output?
Input.
which intent?
Perceptual.
any special flags, black point compensation?
Only black point compensation and the fast float plugin enabled.
to which / from which profile are you doing the transform?
sRGB-elle-V2-srgbtrc (output, 8-bit integer depth).
I'll try to bisect now and see if I can trap the regression.
from little-cms.
The plain CMM without plugin works fine in this configuration. I have to build a tificc with the plugin, maybe the issue is in the plugin. Tomorrow will try to do that.
from little-cms.
Git bisected between lcms2.13.1 and current HEAD (with a couple edits to build the fast float plugin under Meson-- btw, thanks for having it!)
Seems that one of the optimizations went awry:
❯ git bisect bad
d24a40c9cc685b7145e8082606d5d9384d08e472 is the first bad commit
commit d24a40c9cc685b7145e8082606d5d9384d08e472
Author: Marti Maria <[email protected]>
Date: Sun Feb 20 16:07:41 2022 +0100
Fix LUT based optimization on 8 bits
Most times, optimization was discarded where it could be used. Monotonicity is not needed here. Added a small demo.
plugins/fast_float/src/fast_8_tethra.c | 6 +-
plugins/fast_float/testbed/demo_cmyk.c | 151 +++++++++++++++++++++++++++++++++
2 files changed, 152 insertions(+), 5 deletions(-)
create mode 100644 plugins/fast_float/testbed/demo_cmyk.c
from little-cms.
This makes sense.
Seems a bug in the plug-in to me.
The bug was hidden in 2.13.1 because the profile was rejected for the plug-in and handled by the core engine. Now it is accepted, so the bug shows up. Will try to fix it ASAP.
from little-cms.
This is a nasty bug on the plugin. Only affects 8 bits and CMYK. I will temporally disable CMYK on it 8 bits since the speed improvement is very small.
from little-cms.
See 328c226
from little-cms.
Fixed in 2.15
from little-cms.
@mm2 judging by the commit log, it seems there was no better solution found yet, right?
from little-cms.
Related Issues (20)
- A crash found in cmsGetPostScriptCRD by fuzzing. HOT 1
- An heap overflow found in cmsStageAllocMatrix by fuzzing. HOT 1
- A potential off-by-one overflow in cmsIT8SaveToMem HOT 1
- Pack/Unroll for the common formats are not implemented HOT 5
- `meson test` doesn't run test suite like `make check` did in autotools build HOT 3
- CI: Set minimal permissions to your GitHub Workflows HOT 6
- 2.15: build fails because missing `sqrt()` detection HOT 4
- [IT8] Out-of-bound array access on WriteDataFormat HOT 3
- [IT8] Out-of-bound array access in CookPointers HOT 1
- Fast float plugin clamps values to [0,1] HOT 1
- Vector and matrix documentation fixes, and about curves HOT 17
- Support for Oklab/Oklch? HOT 18
- 2.15: failure to build fastfloat plugin on mingw64 HOT 2
- Create Security Policy
- threaded plugin feature request: adjust maximum threads after initialization HOT 4
- threading plugin feature request: allow to replace the threading backend HOT 2
- fast float: compiler warning about misleading indentation HOT 2
- Fast float plugin causes incorrect results in sRGB to XYZ transform
- Ship separate pkgconf files for plugins HOT 4
- Suggest Adoption of Scorecard GitHub Action HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from little-cms.