Using OTP to encrypt urls about dcrypt

[mmeyer2k]

I'm not sure if this is the only problem but in this block...

    private function decrypt() {
        $plaintext = \Dcrypt\Otp::crypt($this->password,hex2bin($this->URL));
        return $plaintext;
    }

... the parameters are not in the correct order. Data should be first, password second.

[khavishbhundoo]

@mmeyer2k Ahh that was stupid.What are your views on the implementation , my use case is to try to generate unique encrypted hash even for same plaintext.

[mmeyer2k]

Stream ciphers are good for that because they don't have IVs. But they also don't have checksums, so be careful!

[mmeyer2k]

Hey one more thing. If the size is of the output is important use base62 encoding instead of hex. It is a more compact representation of the binary and is still URL safe.

[khavishbhundoo]

I was thinking about base64 and then url encoding.

…

On Fri, May 3, 2019, 9:25 PM mmeyer2k ***@***.***> wrote: Hey one more thing. If the size is of the output is important use base62 encoding instead of hex. It is a more compact representation of the binary and is still URL safe. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENH6YNMZL7GYF65BFUTL2DPTRYQ7ANCNFSM4HJU4I7A> .

[mmeyer2k]

That works but base62 encoding will look better and in some cases will be more compact.

I like this one:

https://github.com/tuupola/base62