Whitespace in Chrome App name about mobile-chrome-apps

[clelland]

Are you referring to the app name in the manifest.json file? A space in that value shouldn't cause a problem: it's actually part of the Chrome Spec test application, which gets built all the time.

The app name should be passed into the cordova-android/bin/create script, which sanitizes it with:

var safe_activity_name = project_name.replace(/\W/, '');

On my machine, building Chrome Spec (App name: "Chrome Spec") results in a ChromeSpec.java file, and a ChromeSpec activity class within it.

Do you have a sample project (or even just a manifest) that can reproduce this?

[gapipro]

Yes I am referring to app name in manifest.json.

It doesn't remove whitespace even on latest dev branch.

{
"app": {
"background": {
"scripts": ["background.js"]
}
},

"icons": {
"128": "img/icon128.png",
"16": "img/icon16.png",
"24": "img/icon24.png",
"32": "img/icon32.png",
"48": "img/icon48.png"
},
"description": "Best way to manage your YouTube subscriptions perfectly!",
"name": "YouTube Video Deck Dev",
"minimum_chrome_version": "29",
"permissions": [ "storage", "webview", "identity", "notifications","unlimitedStorage", "https://.ytimg.com/" ,"https://.videodeck.net/" , "http://gdata.youtube.com/","https://apis.google.com/"],
"version": "0.8.7.3",
"sandbox": {
"pages": ["ga/embedded_ga_host.html"]
},
"manifest_version":2
}

[clelland]

That's really strange -- It may be possible that you have a cached version of cordova-android that is not correctly handling this. Right now, mca.js internally invokes cordova-cli, which will look in your home directory for a hidden folder called .cordova, and will prefer the version of cordova-android which is linked there over the version in your mobile-chrome-apps checkout.

You can check the version there -- on my machine, I see the create script in ~/.cordova/lib/android/cordova-mca/mca/bin/create, and its library in ~/.cordova/lib/android/cordova-mca/mca/bin/lib/create.js. If it's wrong, I would try removing ~/.cordova and recreating the project.

(I delete that directory all the time; its purpose is to cache packages that might otherwise be downloaded from the internet every time you run cordova, but sometimes it seems to cache a bit too aggressively).

[clelland]

Just looked at that code again -- the RegExp.replace call is only going to handle the first space in the app name. I think that Andrew may be fixing that in Cordova-android, but it's definitely a bug there.

Thanks

[mmocny]

Just tried this, and it seems resolved.

Please re-open if thats not true.