Comments (4)
👋 As a follow up from corresponding issue in Datadog iOS SDK, we managed to collect Kronos telemetry which shows an evidence of resolving NTP pool to a private / local IP in some (unknown) circumstances. As a fix, we're going to apply private IP filtering in DataDog/dd-sdk-ios#830 on our side. We believe this could be a desired change to Kronos lib as well.
from kronos.
i can reproduce the issue only with local NTP pools, such as 127.0.0.1 or 127.255.255.255:
Clock.sync(from: "127.0.0.1", ...) { ... }
otherwise i can't reproduce the issue and Kronos source code doesn't seem to try to access local network by itself.
can you please make sure that your NTP pool isn't in your local network by any chance?
from kronos.
Interestingly I have been setting up test environments to try and get this to trigger and failed. Until today.
On a cellular connection with a VPN active I got the prompt!
from kronos.
Thanks @ncreated !
I have opened PR #100 which includes DataDog's changes. Let me know if there are any issue with it.
from kronos.
Related Issues (20)
- Async/Await HOT 1
- How does Kronos handle lack of connection / reachability changes? HOT 2
- Xcode 14.3 compatibility needed to resolve error: libarclite_iphonesimulator.a file not found HOT 2
- Showing All Messages The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation. HOT 1
- Does Kronos Implement Based on RFC 5905 standard?
- Add Privacy Manifest file on Kronos HOT 11
- Kronos not working on cellular data but only on Wifi? HOT 5
- Install with Swift packager issue HOT 2
- Not working with Catalyst HOT 1
- Dangling pointer in Data+Byte.swift
- Apple Watch support HOT 1
- Kronos warning for not being Swift 5 HOT 4
- Is it possible to use multiple NTP hosts? HOT 4
- Crash in NTPPacket.swift HOT 5
- Binary distribution plans? HOT 6
- Data race in static Kronos.Clock.annotatedNow.getter HOT 2
- Support for dylib for SPM? HOT 1
- Synced Clock for AR Session
- Swift runtime failure: Double value cannot be converted to UInt32 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kronos.