GithubHelp home page GithubHelp logo

Comments (4)

ncreated avatar ncreated commented on June 10, 2024 1

👋 As a follow up from corresponding issue in Datadog iOS SDK, we managed to collect Kronos telemetry which shows an evidence of resolving NTP pool to a private / local IP in some (unknown) circumstances. As a fix, we're going to apply private IP filtering in DataDog/dd-sdk-ios#830 on our side. We believe this could be a desired change to Kronos lib as well.

from kronos.

buranmert avatar buranmert commented on June 10, 2024

i can reproduce the issue only with local NTP pools, such as 127.0.0.1 or 127.255.255.255:

Clock.sync(from: "127.0.0.1", ...) { ... }

otherwise i can't reproduce the issue and Kronos source code doesn't seem to try to access local network by itself.

can you please make sure that your NTP pool isn't in your local network by any chance?

from kronos.

leearmstrong avatar leearmstrong commented on June 10, 2024

Interestingly I have been setting up test environments to try and get this to trigger and failed. Until today.

On a cellular connection with a VPN active I got the prompt!

from kronos.

jeannustre avatar jeannustre commented on June 10, 2024

Thanks @ncreated !

I have opened PR #100 which includes DataDog's changes. Let me know if there are any issue with it.

from kronos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.