urllib2.urlopen without timeout can be extremely slow about facebook-sdk

[Visgean]

here is my implementation: Visgean/facebook-sdk@f8f05f9

[martey]

This is a positive change, but will break Python 2.5 support. I do not think very many people are still using 2.5, though.

[Visgean]

http://stackoverflow.com/questions/2084782/timeout-for-urllib2-urlopen-in-pre-python-2-6-versions here I can see that there is another solution, it might be better to have this in init:

def __init__(self, access_token=None, timeout=1):
        self.access_token = access_token
        socket.setdefaulttimeout(timeout)

the question is what should be the default timeout - I have look to my facebook insights and average FQL takes about 84ms to process... but of course that is only time on their servers.. And it does not brake the <2.6 compatibility

[martey]

Maybe something like:

def __init__(self, access_token=None, timeout=None):
    self.access_token = access_token
    self.timeout = timeout

# Extraneous code redacted...

def request(self, path, args=None, post_args=None):
    # Extraneous code redacted...
    try:
        file = urllib2.urlopen("https://graph.facebook.com/" + path + "?" +
                urllib.urlencode(args), post_data, timeout=self.timeout)
    except TypeError:
        # We are running in Python 2
        if self.timeout:
            socket.setdefaulttimeout(self.timeout)
            urllib2.urlopen("https://graph.facebook.com/" + path + "?" +
                    urllib.urlencode(args), post_data)

This would only allow to not have a timeout if they did not want to, would only set the default socket timeout if we are running in Python 2 and a timeout has been set (which is important because it can break other applications), and not break backwards compatibility for people currently using the application.

@Visgean, if you submit a pull request with these changes, I will approve it and roll out a new version to PyPi.