api_request method (REST API) is broken about facebook-sdk

[shashank025]

This seems to fix it:

$ diff -u facebook.py.bak facebook.py
--- facebook.py.bak 2012-11-10 23:43:24.000000000 -0800
+++ facebook.py 2012-11-10 23:44:49.000000000 -0800
@@ -336,7 +336,7 @@
                 post_args["access_token"] = self.access_token
             else:
                 args["access_token"] = self.access_token
-        if self.api_key:
+        if hasattr(self, 'api_key') and self.api_key:
             if post_args is not None:
                 post_args["api_key"] = self.api_key
             else:

[martey]

Hi @shashank025,

First, thank you for reporting this issue.

The api_request method is for accessing Facebook's old REST API. While your patch does get rid of the error, no other method of the GraphAPI object sets self.api_key, so I am leaning toward removing that entire code block.

One reason I have not yet is because the REST API has been officially deprecated for almost a year, so I suspect most (if not all) app developers have migrated to the Graph API (which is better supported by both Facebook and this library). I think it would make sense to remove the entire app_request method from the library.

Are you (or anyone else reading this) still using the REST API?

[shashank025]

I am actually not using the REST API. Soon after reporting this, I just switched over to the Graph API. But yes, I'd like it if you simply removed that code block, which is kinda dead now. Thanks!