GithubHelp home page GithubHelp logo

Move to monorepo about mobx.dart HOT 14 CLOSED

mobxjs avatar mobxjs commented on May 19, 2024
Move to monorepo

from mobx.dart.

Comments (14)

rrousselGit avatar rrousselGit commented on May 19, 2024 1

I can potentially help for the flutter sides if needed. 😄

from mobx.dart.

rrousselGit avatar rrousselGit commented on May 19, 2024 1

the issue with mono_repo is that is doesn't support flutter yet. I made a PR so that it won't crash, but it doesn't automatically download the Flutter sdk and run commands.

This is still doable by using command: in the yaml, and manually filling the gap though.

from mobx.dart.

pavanpodila avatar pavanpodila commented on May 19, 2024

Awesome @rrousselGit. I think this will speed up the move to monorepo as well. Ideally this code should live in the flutter_mobx_hooks project.

🤔 One other option is you can create the hooks code in a separate folder to get started. Once you have it working, we can extract it out to flutter_mobx_hooks. 🤔

from mobx.dart.

katis avatar katis commented on May 19, 2024

I can try to tackle this after work. mono_repo seems to be used by few projects.

from mobx.dart.

katis avatar katis commented on May 19, 2024

@pavanpodila I've tried various approaches to make a mono repo, but either I can't get them to work, or they seem to bring more complexity than they're worth.

I say we create separate repositories for the packages for now, and see about a monorepo later.
Is it possible to add the repositories to mobxjs org?

from mobx.dart.

pavanpodila avatar pavanpodila commented on May 19, 2024

Do we even need separate repositories ? I suggest we keep the packages together under this repo and publish separately? I think maintenance is much easier if they are all together. At least at this stage where the packages are still maturing. What say?

from mobx.dart.

pavanpodila avatar pavanpodila commented on May 19, 2024

And agree about skipping the whole mono_repo dependency. We can add that later if it works out.

from mobx.dart.

katis avatar katis commented on May 19, 2024

You are of course right about the ease of maintenance from a cross-package point of view, but Travis configuration becomes a problem. With a single package repository the ready made configs of language: dart work well, but with multiple packages you have to write the scripts yourself. I'm not that familiar with Travis, so I couldn't figure out how the config would work. If you want to try, you're welcome, but I'm out of ideas.

from mobx.dart.

rrousselGit avatar rrousselGit commented on May 19, 2024

I would heavily suggest to send a mail to Flutter for this.

Because the community has been small until now, Flutter team haven't really noticed the monorepository issue.

from mobx.dart.

pavanpodila avatar pavanpodila commented on May 19, 2024

I think in principle the monorepo idea is good, so we can keep the two packages (mobx and flutter_mobx) together. If it means replicating the Travis scripts, I'm ok for now as there are only two packages. I can do the duplication but it is not that hard, just a matter of fixing the paths in travis.sh.

Let's get flutter_mobx working for now removing any mono_repo boilerplate? I'll help out with the travis.sh scripts when you are ready.

Also as @rrousselGit suggested, we should get in touch with Flutter to share our specific issue? @katis could you raise an issue detailing where you found problems ?

from mobx.dart.

pavanpodila avatar pavanpodila commented on May 19, 2024

On a separate note, @rrousselGit can you take a look at the PR (#34) to see if there are any obvious fixes?

from mobx.dart.

katis avatar katis commented on May 19, 2024

That PR is probably not that useful starting point atm., I made a bit of a mess of it

from mobx.dart.

rrousselGit avatar rrousselGit commented on May 19, 2024

I don't see anything special. Looks good :)

from mobx.dart.

katis avatar katis commented on May 19, 2024

This is done.

from mobx.dart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.