Comments (4)
react-dom is deliberately not part of the deps as it breaks with react-native. However, with normal node resolution rules, that shouldn't matter, as a module should resolve as long as it appears anywhere in node_modules. So make sure react-dom is a dependency of the "host" or top level package.json, or the same package.json that requires mobx-react-lite and you should be fine.
I think the real issue here is that @Redocly puts react-dom in their dependencies instead of peer-dependencies; a project should have only a single version of react and react-dom , which is why you want those always as peer deps in libraries, so that the owning project can "configure" the actual react / react-dom version for everyone.
from mobx.
redocly provides a binary document generator. It's not some form of lib or component that one includes in their own application. So their approach of depending on a specific version of react is correct.
The peerDeps of mobx-react-lite are currently invisible to any package manager, because they are only listed in the meta but not in the peerDeps themselves. They are marked as optional, so package managers should not install these during a normal add/install. So I'm not sure there would be an actual conflict between native and dom
from mobx.
Ah I see what you are getting at. But as far as I understand with optional it won't be installed either? Would you mind doing a quick test that if [email protected]
does indeed install things correctly?
from mobx.
I tested it and unfortunately, you are right and it still can not be found. I did hope that npm will put it into the right location but it didn't. Bummer.
from mobx.
Related Issues (20)
- Cannot update past `6.10.0` HOT 1
- Supporting of new Set methods in observable Sets HOT 3
- [feature] Investigate running MobX on top of signals standard / polyfill HOT 1
- [eslint-plugin-mobx] ESLint v9 Support
- `isolateGlobalState: true` can cause conflicts that prevent observable registration
- [mobx-react] `Maximum update depth exceeded` error since `mobx-react@8` HOT 5
- makeAutoObservable can't detect a generator after adding a default parameter value HOT 6
- Incompatible with React Forget compiler HOT 3
- [eslint-plugin-mobx] `mobx/exhaustive-make-observable` autofix behavior should be inversed HOT 4
- Converting functions to actions (autoActions?) in deep enhancer leads to bugs HOT 5
- @action decorators on fields do not convert the field value into action HOT 10
- New computed decorator does not apply action to setter HOT 4
- Reaction is not triggering When listening to a local observable. HOT 1
- TypeScript 5.5 compatibility for `ObservableSet` HOT 2
- Cannot initialize observable Map/Sets from another window HOT 2
- Cannot apply 'observable' to '[email protected]' Field not found HOT 2
- Cannot access '__WEBPACK_DEFAULT_EXPORT__' before initialization in react-router-dom v6 loader HOT 2
- Updating to 6.13.0 causing error: `Cannot find name 'ReadonlySetLike'. Did you mean 'ReadonlySet'?` HOT 1
- eslint mobx/missing-observer rule false positive with forwardRef HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mobx.