Comments (6)
@shettyg Was busy integrating libnetwork with docker hence the delay in answering some of your earlier questions. Getting back to this question, the interface SrcName
, DstName
being present as part of the return value of the CreateEndpoint
is an artifact of an earlier design where endpoint was a local resource and a container joined it during CreateEndpoint. With the goal of Endpoint being a service abstraction and hence a universal resource, it makes no more sense to keep interface names as part of information returned during CreateEndpoint
. The IP addresses still will remain as part of CreateEndpont
info. But expect a few adjustments in what needs to be returned during endpoint create and join which will hopefully clarify all these questions. I will probably push a PR tomorrow to fix this. Please take a look and comment.
from libnetwork.
@mrjana Any update on this? This sounds like quite a significant change to the API. If you're not ready to push code for it, could you at least update the design doc (on a branch)?
from libnetwork.
@tomdee I am getting back to working on this. Our first priority was to settle down the libnetwork northbound apis so that we can get it integrated with docker core for which we have a PR in progress. It should probably not be that much of a change in driver API other than only IP addresses required to be returned during CreateEndpoint
and everything else during Join
. I will try to push a PR today and update the doc. If not I will try to see if we can send a doc update PR.
from libnetwork.
@mrjana Thanks for the quick response. That all sounds good.
from libnetwork.
Is this (or rather, the analogous problem with Join) addressed by #193, which changed the meaning of DstName to be a prefix to which libnetwork appends an index?
from libnetwork.
@squaremo Yes, and I think we should close this issue
from libnetwork.
Related Issues (20)
- Use .local suffix for containers on user-defined networks to avoid proxy issues. HOT 1
- docker: firewall: interdocker communication broken when using internal networks HOT 8
- controller deadlock HOT 4
- publishing port from overlay network does not work if not bound on wildcard address in container
- firewalld docker zone not working to reject request HOT 3
- Can't get libnetwork due to github.com/docker/docker/pkg/tlsconfig missing HOT 2
- Failing to attach containers to encrypted overlay network since linux 5.15.17 HOT 4
- Libnetwork is failing while executing command ' get github.com/moby/libnetwork' HOT 3
- Update moby/libnetwork to support golang 1.17 HOT 1
- No DOCKER-USER chain with `ip6tables: true` HOT 13
- Overlay network broken when outside network mtu is smaller than default (1450) HOT 1
- com.docker.network.host_ipv4 does not working when multiple IPs HOT 1
- Embedded swarm DNS does not fail over to secondary properly on RHEL7 HOT 5
- module google.golang.org/grpc@latest found (v1.50.1), but does not contain package google.golang.org/grpc/naming HOT 2
- .go
- After enable ipv6 in the docker, it works for only static ipv6 address, but not DHCP ipv6 address HOT 1
- [Bug]:A potential goroutine leak in libnetwork/drivers/overlay/peerdb.go HOT 2
- [Bug]:A potential goleak
- With firewalld, all docker containers that are listening on 0.0.0.0:PORT are exposed to the outside HOT 1
- OOM-kill in dockerd 20.10, tries to allocate 2³² IPAM subnets
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libnetwork.