GithubHelp home page GithubHelp logo

Comments (6)

mrjana avatar mrjana commented on August 16, 2024

@shettyg Was busy integrating libnetwork with docker hence the delay in answering some of your earlier questions. Getting back to this question, the interface SrcName, DstName being present as part of the return value of the CreateEndpoint is an artifact of an earlier design where endpoint was a local resource and a container joined it during CreateEndpoint. With the goal of Endpoint being a service abstraction and hence a universal resource, it makes no more sense to keep interface names as part of information returned during CreateEndpoint. The IP addresses still will remain as part of CreateEndpont info. But expect a few adjustments in what needs to be returned during endpoint create and join which will hopefully clarify all these questions. I will probably push a PR tomorrow to fix this. Please take a look and comment.

from libnetwork.

tomdee avatar tomdee commented on August 16, 2024

@mrjana Any update on this? This sounds like quite a significant change to the API. If you're not ready to push code for it, could you at least update the design doc (on a branch)?

from libnetwork.

mrjana avatar mrjana commented on August 16, 2024

@tomdee I am getting back to working on this. Our first priority was to settle down the libnetwork northbound apis so that we can get it integrated with docker core for which we have a PR in progress. It should probably not be that much of a change in driver API other than only IP addresses required to be returned during CreateEndpoint and everything else during Join. I will try to push a PR today and update the doc. If not I will try to see if we can send a doc update PR.

from libnetwork.

tomdee avatar tomdee commented on August 16, 2024

@mrjana Thanks for the quick response. That all sounds good.

from libnetwork.

squaremo avatar squaremo commented on August 16, 2024

Is this (or rather, the analogous problem with Join) addressed by #193, which changed the meaning of DstName to be a prefix to which libnetwork appends an index?

from libnetwork.

mrjana avatar mrjana commented on August 16, 2024

@squaremo Yes, and I think we should close this issue

from libnetwork.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.